New issue
Advanced search Search tips

Issue 735175 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 729483



Sign in to add a comment

Failure in ContextLostIntegrationTest on Win7 Debug (NVIDIA).

Project Member Reported by khushals...@chromium.org, Jun 20 2017

Issue description

The test that started failing is ContextLostIntegrationTest.GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash with the following build:

https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/52943

Here is a stack trace:

[1008:724:0620/120904.963:FATAL:crash_logging.cc(59)] Check failed: crash_key. All crash keys must be registered before use (key = gpu-channel-filter-trace)
Backtrace:
	base::debug::StackTrace::StackTrace [0x100AE5D7+55]
	base::debug::StackTrace::StackTrace [0x100AE271+17]
	logging::LogMessage::~LogMessage [0x10102DBE+94]
	base::debug::SetCrashKeyValue [0x100A9BA3+211]
	base::debug::SetCrashKeyFromAddresses [0x100A99D2+418]
	base::debug::SetCrashKeyToStackTrace [0x100A9AAD+45]
	gpu::GpuChannelMessageFilter::~GpuChannelMessageFilter [0x0E8F5D70+64]
	gpu::GpuChannelMessageFilter::`vector deleting destructor' [0x0E8F890D+77]
	base::RefCountedThreadSafe<IPC::MessageFilter,base::DefaultRefCountedThreadSafeTraits<IPC::MessageFilter> >::DeleteInternal [0x0EF029A7+39]
	base::DefaultRefCountedThreadSafeTraits<IPC::MessageFilter>::Destruct [0x0EF02BBC+12]
	base::RefCountedThreadSafe<IPC::MessageFilter,base::DefaultRefCountedThreadSafeTraits<IPC::MessageFilter> >::Release [0x0EF0423A+58]
	scoped_refptr<IPC::MessageFilter>::Release [0x0EF0428E+14]
	scoped_refptr<IPC::MessageFilter>::~scoped_refptr<IPC::MessageFilter> [0x0EF0071A+26]
	scoped_refptr<IPC::MessageFilter>::`scalar deleting destructor' [0x0EF01DDF+15]
	std::allocator<scoped_refptr<IPC::MessageFilter> >::destroy<scoped_refptr<IPC::MessageFilter> > [0x0EEFEF41+17]
	std::allocator_traits<std::allocator<scoped_refptr<IPC::MessageFilter> > >::destroy<scoped_refptr<IPC::MessageFilter> > [0x0EEFEF5F+15]
	std::_Wrap_alloc<std::allocator<scoped_refptr<IPC::MessageFilter> > >::destroy<scoped_refptr<IPC::MessageFilter> > [0x0EEFEF14+20]
	std::_Destroy_range1<std::allocator<scoped_refptr<IPC::MessageFilter> >,scoped_refptr<IPC::MessageFilter> *> [0x0EEFE42B+43]
	std::_Destroy_range<std::allocator<scoped_refptr<IPC::MessageFilter> >,scoped_refptr<IPC::MessageFilter> *> [0x0EEFE48A+26]
	std::vector<scoped_refptr<IPC::MessageFilter>,std::allocator<scoped_refptr<IPC::MessageFilter> > >::_Destroy [0x0EF0506D+29]
	std::vector<scoped_refptr<IPC::MessageFilter>,std::allocator<scoped_refptr<IPC::MessageFilter> > >::clear [0x0EF063EE+46]
	IPC::ChannelProxy::Context::OnChannelClosed [0x0EF0354B+395]
	IPC::SyncChannel::SyncContext::OnChannelClosed [0x0EF3C866+38]
	??$Invoke@ABV?$scoped_refptr@VContext@ChannelProxy@IPC@@@@$$V@?$FunctorTraits@P8Context@ChannelProxy@IPC@@AEXXZX@internal@base@@SAXP8Context@ChannelProxy@IPC@@AEXXZABV?$scoped_refptr@VContext@ChannelProxy@IPC@@@@@Z [0x0EEFD6B3+19]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall IPC::ChannelProxy::Context::*const &)(void),scoped_refptr<IPC::ChannelProxy::Context> const &> [0x0EEFDD98+40]
	base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(void),scoped_refptr<IPC::ChannelProxy::Context> >,void __cdecl(void)>::RunImpl<void (__thiscall IPC::ChannelProxy::Context::*const &)(void),std::tuple<scoped [0x0EEFE184+52]
	base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(void),scoped_refptr<IPC::ChannelProxy::Context> >,void __cdecl(void)>::Run [0x0EF04564+36]
	base::Callback<void __cdecl(void),0,0>::Run [0x1004A9F5+53]
	base::debug::TaskAnnotator::RunTask [0x100B54DC+476]
	base::MessageLoop::RunTask [0x1013AB1C+508]
	base::MessageLoop::DeferOrRunPendingTask [0x10138F92+50]
	base::MessageLoop::DoWork [0x101395E2+274]
	base::MessagePumpForIO::DoRunLoop [0x10141361+33]
	base::MessagePumpWin::Run [0x1014244B+123]
	base::MessageLoop::Run [0x1013A81F+191]
	base::RunLoop::Run [0x101FA32A+186]
	base::Thread::Run [0x1029ECC1+273]
	base::Thread::ThreadMain [0x1029FE0F+863]
	base::PlatformThread::Sleep [0x10276F5C+380]
	BaseThreadInitThunk [0x768F338A+18]
	RtlInitializeExceptionChain [0x77639902+99]
	RtlInitializeExceptionChain [0x776398D5+54]

Most likely caused by https://chromium-review.googlesource.com/c/538056/. I'm reverting the change.
 

Comment 1 by kbr@chromium.org, Jun 20 2017

Blocking: 729483
Thanks for catching this Khushal, and sorry Sunny that the trybots didn't catch this though they build with dcheck_always_on=true.

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e

commit a2c68af4c1ea71c0a841dd9dc281379ab59ef95e
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Fri Jun 23 02:13:09 2017

Reland "gpu: Add message filter destructor stack traces to crash keys."

This is a reland of 1d6296323cdcf31db51b513441a9e10b9f1c0754

I had assumed that unregistered crash keys would be a nop but they need
to be registered or else a DCHECK is triggered.

I also made sure gpu/config/gpu_crash_keys is used as the source of
truth for gpu related crash keys.

Original change's description:
> gpu: Add message filter destructor stack traces to crash keys.
> 
> base::debug::Alias values don't show up in minidumps. Using crash keys
> is recommended for use-after-free bugs in the following doc:
> http://dev.chromium.org/developers/debugging-with-crash-keys
> 
> R=jbauman,rsesek,sandersd
> BUG=729483
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I8fd129daf66dc9235307a28fe5cd7a6c23b85a94
> Reviewed-on: https://chromium-review.googlesource.com/538056
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: John Bauman <jbauman@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480879}

TBR=jbauman,sandersd

Bug: 729483,  735175 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I05c46bb583135dff05d5bc75dff694a1caa54b32
Reviewed-on: https://chromium-review.googlesource.com/541937
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481787}
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/android_webview/BUILD.gn
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/android_webview/common/crash_reporter/crash_keys.h
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/chrome/common/crash_keys.cc
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/chrome/test/BUILD.gn
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/chrome_elf/BUILD.gn
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/chromecast/crash/BUILD.gn
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/chromecast/crash/DEPS
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/gpu/config/gpu_crash_keys.cc
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/gpu/config/gpu_crash_keys.h
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/a2c68af4c1ea71c0a841dd9dc281379ab59ef95e/media/gpu/ipc/service/media_gpu_channel.cc

Status: Fixed (was: Assigned)

Sign in to add a comment