browse:news:reddit failing consistently on win-7 and win-7-x64 |
||||||||||||||
Issue descriptionv8.browsing_desktop failing on 4 builders Builders failed on: - Linux Perf: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf - Win 7 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf - Win 7 x64 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf - Win 8 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf The stories are: Unexpected Failures: * browse:media:imgur * browse:media:pinterest * browse:media:youtube * browse:news:cnn * browse:news:flipboard * browse:news:hackernews * browse:news:nytimes * browse:news:reddit * browse:search:google * browse:search:google_india * browse:social:facebook_infinite_scroll * browse:social:twitter It's confusing re: exactly how long the tests have been failing for. At least on Linux, the tests were passing as recently as June 17, but only for a short while before they reverted to failing. On other bots, like Windows, it seems like they stayed failing. I'm going to go ahead and disable these stories on the failing platforms.
,
Jun 20 2017
The bizarre thing is that it just looks like Chrome is crashing for these failed tests, and I'd expect such a crash to happen on all bots of a particular platform. However, it looks like (maybe) this is only happening on (some?) desktop bots.
,
Jun 20 2017
cnn, nytimes, imgur, and reddit seem to be failing on Windows.
,
Jun 20 2017
,
Jun 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a9c87597190199c597dc006d90e1b31e8446d80 commit 5a9c87597190199c597dc006d90e1b31e8446d80 Author: Charlie Andrews <charliea@google.com> Date: Tue Jun 20 23:19:40 2017 Disable failing v8.browsing_desktop stories NOTRY=true TBR=ulan@chromium.org Bug: 735173 Change-Id: Iac9cceb3f5a05aa249d1565337602f2a65b4ee79 Reviewed-on: https://chromium-review.googlesource.com/541607 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#481020} [modify] https://crrev.com/5a9c87597190199c597dc006d90e1b31e8446d80/tools/perf/page_sets/system_health/expectations.py
,
Jun 22 2017
Windows bots crash on memory dump. Primiano, any known recent issue related to crashes on memory dump? ChildEBP RetAddr Args to Child 002be020 6d965fed 002be03c 09f73be8 095c91c0 chrome!cc::ResourceProvider::OnMemoryDump+0x190 002be134 6d965c73 0cd2da90 095ca990 6f9b7be0 chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x1dd 002be22c 6d96604e 00000000 095ca990 0cd2da90 chrome!base::trace_event::MemoryDumpManager::SetupNextMemoryDump+0xc3 002be33c 6d965c73 0cd2da90 095c8fe0 6f9b7be0 chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x23e 002be434 6d96604e 00000000 095c8fe0 0cd2da90 chrome!base::trace_event::MemoryDumpManager::SetupNextMemoryDump+0xc3 002be544 6d965c73 0cd2da90 09f16ff8 6f9b7be0 chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x23e 002be63c 6d96604e 00000000 09f16ff8 0cd2da90 chrome!base::trace_event::MemoryDumpManager::SetupNextMemoryDump+0xc3 002be74c 6d965c73 0cd2da90 095c8fb0 6f9b7be0 chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x23e 002be844 6d96604e 00000000 095c8fb0 0cd2da90 chrome!base::trace_event::MemoryDumpManager::SetupNextMemoryDump+0xc3 002be954 6d965c73 0cd2da90 095c8d10 6f9b7be0 chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x23e 002bea4c 6d96604e 00000000 095c8d10 0cd2da90 chrome!base::trace_event::MemoryDumpManager::SetupNextMemoryDump+0xc3 002beb5c 6d965c73 0cd2da90 09f16fc8 6f9b7be0 chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x23e 002bec54 6d96604e 00000000 09f16fc8 0cd2da90 chrome!base::trace_event::MemoryDumpManager::SetupNextMemoryDump+0xc3 002bed64 6d965c73 0cd2da90 09f170b8 6f9b7be0 chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x23e 002bee5c 6d96604e 00000000 09f170b8 0cd2da90 chrome!base::trace_event::MemoryDumpManager::SetupNextMemoryDump+0xc3 002bef6c 6d965c73 0cd2da90 09f16f38 6f9b7be0 chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x23e 002bf064 6d96604e 00000000 002bf320 0ddbee18 chrome!base::trace_event::MemoryDumpManager::SetupNextMemoryDump+0xc3 002bf170 6d9681d1 0cd2da90 002bf260 6d9a32dc chrome!base::trace_event::MemoryDumpManager::InvokeOnMemoryDump+0x23e 002bf17c 6d9a32dc 0ddbee18 02568758 6f9b7b5c chrome!base::internal::Invoker<base::internal::BindState<void (__thiscall base::StackSamplingProfiler::SamplingThread::*)(int),base::internal::UnretainedWrapper<base::StackSamplingProfiler::SamplingThread>,int>,void __cdecl(void)>::Run+0x11 002bf260 6d95d968 6f94c290 002bf320 ffffffff chrome!base::debug::TaskAnnotator::RunTask+0x20c 002bf2ec 6d95e368 002bf320 00000000 02749718 chrome!base::MessageLoop::RunTask+0x2f8 002bf3c8 6d9a38dd 00000000 02749718 6f94c26c chrome!base::MessageLoop::DoWork+0x478 002bf3f8 6d9a34a5 00000000 002bf4b8 02568758 chrome!base::MessagePumpForUI::DoRunLoop+0x5d 002bf424 6d97a506 02568758 025685f0 6d909016 chrome!base::MessagePumpWin::Run+0x55 002bf4a4 6e3a995f 00000000 0275c100 6f94c26c chrome!base::RunLoop::Run+0x66 002bf4d0 6df95c0a 0275c110 ffffffff 02565888 chrome!ChromeBrowserMainParts::MainMessageLoopRun+0x92 002bf4e4 6df96c49 02565888 6df92c3e 00000000 chrome!content::BrowserMainLoop::RunMainMessageLoopParts+0x50 002bf4ec 6df92c3e 00000000 025604d8 02724f70 chrome!content::BrowserMainRunnerImpl::Run+0xb 002bf504 6e32f35b 002bf538 00000000 002bf59c chrome!content::BrowserMain+0x82 002bf514 6e32f2cd 002bf580 002bf538 002bf6a0 chrome!content::RunNamedProcessTypeMain+0x5d 002bf59c 6e34407c 00a7eae0 00000000 00a6a8d0 chrome!content::ContentMainRunnerImpl::Run+0x115 002bf660 6e32ec7c 002bf68c 00000000 6f4a171c chrome!service_manager::Main+0x1e6 002bf690 6dd6fe22 002bf6c0 00000000 6f3e3220 chrome!content::ContentMain+0x27 *** WARNING: Unable to verify checksum for chrome.exe 002bf6d4 00f62c97 00f10000 002bf6f8 98cbec6f chrome!ChromeMain+0xab 002bf75c 00f6220a 00f10000 98cbec6f 00000001 chrome_exe!MainDllLoader::Launch+0x1bd 002bf8a8 00f84eb8 00f10000 00000000 006e27ae chrome_exe!wWinMain+0x1a2 *** WARNING: Unable to verify checksum for kernel32.dll
,
Jun 22 2017
The crash does not reproduce on my linux machine.
,
Jun 22 2017
Hmm there was a recent change in cc MDP in https://chromium-review.googlesource.com/526816 but not sure if that could have caused a failure here (+hajimeoshi, is that code path hit yet?) +perezju and +ned in case they saw something similar
,
Jun 22 2017
On system health we've seen linux failures on issue 732463 , but not in windows. Strange why this only happens on the v8 benchmarks? On one of the windows bots the streak of failures started at: https://luci-milo.appspot.com/buildbot/chromium.perf/Win%207%20Perf/823 with CL range: http://test-results.appspot.com/revision_range?start=478924&end=478999 I'll try a return code bisect there.
,
Jun 22 2017
TL;DR: On a second look, there appear to be three issues conflated here: 1) browse:news:reddit failing consistently on win-7 and win-7-x64. 2) failures on linux are dupe of issue 732463 . 3) flakes on other stories on windows. I'll keep this issue to investigate 1, and kick off a return code bisect for that. Not sure how much else to do about flaky stories in 3? Now to the details ... The linux failures look like: https://luci-milo.appspot.com/buildbot/chromium.perf/Linux%20Perf v8.browsing_desktop build status test browse:media:imgur 794 ~FFFFFFF~~--FFFFF-F~~FFFFFFFFFFFFFFF-------------- browse:media:pinterest 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:media:youtube 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:news:cnn 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:news:flipboard 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:news:hackernews 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:news:nytimes 794 ~FFFFFFF~~--FFFFF-F~~FFFFFFFFFFFFFFF-------------- browse:news:reddit 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:search:google 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:search:google_india 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:social:facebook_infinite_scroll 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- browse:social:twitter 794 ~FFFFFFF~~--FFFF--F~~FFFFFFFFFFFFFFF-------------- These are the failures being tracked at issue 732463 On two on the windows bots we see browse:news:reddit failing consistently, and a few other stories randomly flaking. https://luci-milo.appspot.com/buildbot/chromium.perf/Win%207%20Perf v8.browsing_desktop build status test browse:media:imgur 853 ~---------------F---F---F------------------------- browse:media:tumblr 853 ~---F-F-------------F----------------------------- browse:media:youtube 853 ~-------------------F-F--F------------------------ browse:news:cnn 853 ~-------------------F----------------------------- browse:news:flipboard 853 ~---------------------F--------------------------- browse:news:nytimes 853 ~---F-----------------FF----F--------------------- browse:news:reddit 853 ~---FFFFFFFFFFFFFFFFFFFFFFFFFFF------------------- https://luci-milo.appspot.com/buildbot/chromium.perf/Win%207%20x64%20Perf v8.browsing_desktop build status test browse:media:pinterest 867 -~----------------F------------------------------- browse:media:youtube 867 -~-----F------------------------------------------ browse:news:cnn 867 -~---F---F------------F-----F--------------------- browse:news:nytimes 867 -~---F-------------------FF----------------------- browse:news:reddit 867 -~---FFFFFFFFFFFFFFFFFFFFFFFFFFF------------------ browse:social:tumblr_infinite_scroll 867 -~---------------F-------------------------------- On the final windows bot, there were just some stories flaking: https://luci-milo.appspot.com/buildbot/chromium.perf/Win%208%20Perf v8.browsing_desktop build status test browse:media:imgur 897 -~--------F------------F-F------------------------ browse:news:cnn 897 -~-----F--F-----------------FFF------------------- browse:news:nytimes 897 -~----FF------F--FF------F--F---F-F--------------- browse:news:reddit 897 -~----F---F-F-----F--FF--F----FF------------------ browse:search:google_india 897 -~--F-----------------F--F------F-F--------------- browse:social:facebook_infinite_scroll 897 -~------------------------------F----------------- browse:social:tumblr_infinite_scroll 897 -~F-----------------------------------------------
,
Jun 22 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976081947677697312
,
Jun 22 2017
Thanks a lot for investigation! > 3) flakes on other stories on windows. I checked one failure of browse:news:cnn (https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_Perf%2F833%2F%2B%2Frecipes%2Fsteps%2Fv8.browsing_desktop_on__102b__GPU_on_Windows_on_Windows-2008ServerR2-SP1%2F0%2Fstdout). It has the same memory dump stack trace. So the underlying issue seems the same as in the reddit story. For some reason it is flaky.
,
Jun 22 2017
=== Auto-CCing suspected CL author tansell@chromium.org === Hi tansell@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : tansell Commit : 48d4f56053dec8d56dd0a1caa1fb253ebba3b8ec Date : Tue Jun 13 12:21:46 2017 Subject: chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Bisect Details Configuration: win_perf_bisect Benchmark : v8.browsing_desktop Metric : memory:chrome:renderer_processes:process_count_avg/browse_news/browse_news_reddit Revision Exit Code N chromium@478923 1 +- N/A 5 good chromium@478961 1 +- N/A 5 good chromium@478971 1 +- N/A 5 good chromium@478976 1 +- N/A 5 good chromium@478978 1 +- N/A 5 good chromium@478979 1 +- N/A 5 good chromium@478980 0 +- N/A 5 bad <-- chromium@478999 0 +- N/A 5 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.reddit v8.browsing_desktop Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976081947677697312 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5822666390372352 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 22 2017
I'm going to try to re-run the bisect, but it looks like the test is really flaky :( The bisect in #14 says that tansell's change FIXED the crash, which is just as unlikely as having caused it.
,
Jun 22 2017
#15: is return code bisect not able to deal with flaky test? I thought it uses the "AND" logic on some number of repeats.
,
Jun 22 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976059077380591072
,
Jun 22 2017
+simonhatch see #16
,
Jun 22 2017
re: #c16 The test only ran 5 times, and 478980 didn't crash in those 5 so the bisect marked it as good. The new bisect seems to have a higher # runs selected (20), so most likely won't converge on the same answer.
,
Jun 22 2017
=== BISECT JOB RESULTS === NO Test failure found Bisect Details Configuration: win_perf_bisect Benchmark : v8.browsing_desktop Metric : memory:chrome:renderer_processes:process_count_avg/browse_news/browse_news_reddit Revision Exit Code N chromium@478923 1 +- N/A 20 good chromium@478999 1 +- N/A 20 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.reddit v8.browsing_desktop Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976059077380591072 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6367946311467008 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 23 2017
+ssid
,
Jun 23 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8976008238640925680
,
Jun 23 2017
Trying again on a wider range. Would be great if the output from return code bisect returned the failure rate, rather than just "0/1".
,
Jun 23 2017
I want FindIt so badly...
,
Jun 23 2017
=== Auto-CCing suspected CL author hajimehoshi@chromium.org === Hi hajimehoshi@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : Hajime Hoshi Commit : 35e4fd70b755009eb78195ed9dfe0e8a3a21ba0f Date : Tue Jun 13 03:10:40 2017 Subject: Switch ownership edges of global shared dumps for base::SharedMemory Bisect Details Configuration: win_perf_bisect Benchmark : v8.browsing_desktop Metric : memory:chrome:renderer_processes:process_count_avg/browse_news/browse_news_reddit Revision Exit Code N chromium@478700 0 +- N/A 20 good chromium@478850 0 +- N/A 20 good chromium@478869 0 +- N/A 20 good chromium@478874 0 +- N/A 20 good chromium@478876 0 +- N/A 20 good chromium@478877 1 +- N/A 20 bad <-- chromium@478879 1 +- N/A 20 bad chromium@478888 1 +- N/A 20 bad chromium@478925 1 +- N/A 20 bad chromium@478999 1 +- N/A 20 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.reddit v8.browsing_desktop Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8976008238640925680 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6495117071876096 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 26 2017
I'm a bit confused. According to the comment #10, the bug is duped with crbug/732463, which is found before https://chromium-review.googlesource.com/c/526816/ is landed. On the other hand, the crash log says https://chromium-review.googlesource.com/c/526816/ seems suspicious. I couldn't reproduce this on my local Linux machine, neither.
,
Jun 26 2017
hajimehoshi@, please read comment #10. Linux failures are dupe of crbug/732463. Windows failure is caused by 35e4fd70b75 according to bisect in comment #25. Note that this failure is Windows specific and does not repro on Linux.
,
Jun 26 2017
Ah, OK thanks. I'm now trying this on Windows machine.
,
Jun 26 2017
Hmm, I couldn't reproduce this on Windows 10. The command that I tried is $ python /tools/perf/run_benchmark -v --browser=default --output-format=chartjson --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.reddit v8.browsing_desktop and the result is just PASSED.
,
Jun 26 2017
Well, the comment #10 says that this can be reproduced only on Windows 7 stably and not 8 (and probably later?). ulan@, is there a way to run a try bot 'win 7 perf' with a CL? I tried some commands like below but failed: $ git cl try -b win7_perf -m tryserver.chromium.perf
,
Jun 26 2017
ulan@, is there a way to run a try bot 'win 7 perf' with a CL? I don't know, deferring this question to perezju@ and nednguyen@
,
Jun 26 2017
The following should be enough to repro on a try bot: $ tools/perf/run_benchmark try win v8.browsing_desktop --pageset-repeat=20 --story-filter=browse.news.reddit You can also run e.g.: $ tools/perf/run_benchmark try list To get a list of all supported bots.
,
Jun 26 2017
,
Jun 27 2017
> $ tools/perf/run_benchmark try win v8.browsing_desktop --pageset-repeat=20 --story-filter=browse.news.reddit Thanks, I could run 'win' try bots https://chromium-review.googlesource.com/c/547403/win and confirm the actual failures https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Ftryserver.chromium.perf%2Fwin_perf_bisect%2F7481%2F%2B%2Frecipes%2Fsteps%2FRunning_WITH_patch%2F0%2Fsteps%2FPerformance_Test__With_Patch__1_of_1%2F0%2Flogs%2FFailure_Output%2F0
,
Jun 28 2017
+danakj Comments derived from crbug/661182 * Comment #40: https://chromium-review.googlesource.com/c/547403/3 I have confirmed that the above CL fixes the issues on win(7) bots. +danakj@: Is the above fix valid? I found |shared_bitmap| can be only when 1. GPU is disabled (on win 7 bots, gpu doesn't work? I'm not sure) 2. Resource is created without a shared bitmap (this can happen when software rendering is used, and shared bitmap is set at ResourceProvider::LockForRead) 3. ResourceProvider::OnMemoryDump is called before ResourceProvider::LockForRead is called These are just guessing. I couldn't reproduce this on my local machines. * Comment #41: That sounds right, left you a question on the CL. * Comment #42: > 2. Resource is created without a shared bitmap (this can happen when software rendering is used, and shared bitmap is set at ResourceProvider::LockForRead) This means the resource was made with a SharedBitmapId instead.
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ef4160b5770c280def9169f04685e3224bc6a96 commit 1ef4160b5770c280def9169f04685e3224bc6a96 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Jun 28 19:00:26 2017 Bug fix: cc::Resource's shared_bitmap can be null even when it has shared-bitmap ID This can happen when 1. GPU is disabled 2. Resource is created without a shared bitmap (this can happen when software rendering is used, and shared bitmap is set at ResourceProvider::LockForRead) 3. ResourceProvider::OnMemoryDump is called before ResourceProvider::LockForRead is called Now shared_bitmap is referenced at ResouceProvider::OnMemoryDump and some Windows bots have been crashing. This CL fixes those crashes. Bug: 735173 , 604726 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic063f54cab613ba55810fa4bd01da6a9d1077fe0 Reviewed-on: https://chromium-review.googlesource.com/547403 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: siddhartha sivakumar <ssid@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#483088} [modify] https://crrev.com/1ef4160b5770c280def9169f04685e3224bc6a96/cc/resources/resource_provider.cc
,
Jun 29 2017
I think it is fixed. perezju@, should we keep https://chromium-review.googlesource.com/c/541607/ as it is? I think this includes the expectations not only for this issue but also other issue like issue 732463 .
,
Jun 29 2017
Yep, that's fine. Landing revert to re-enable stories here: https://chromium-review.googlesource.com/c/554754 The linux bot on issue 732463 is having more widespread issues that can't be solved by disabling a few stories.
,
Jun 29 2017
I'll close this as fixed and re-open if issues reoccur.
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c2854bff7e7db58e3d09d691590b634df58759b commit 1c2854bff7e7db58e3d09d691590b634df58759b Author: Ulan Degenbaev <ulan@chromium.org> Date: Thu Jun 29 13:11:43 2017 Revert "Disable failing v8.browsing_desktop stories" This reverts commit 5a9c87597190199c597dc006d90e1b31e8446d80. Reason for revert: the bug in chrome was fixed: crbug.com/735173 Original change's description: > Disable failing v8.browsing_desktop stories > > NOTRY=true > TBR=ulan@chromium.org > > Bug: 735173 > Change-Id: Iac9cceb3f5a05aa249d1565337602f2a65b4ee79 > Reviewed-on: https://chromium-review.googlesource.com/541607 > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481020} TBR=ulan@chromium.org,charliea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 735173 Change-Id: I01ef0acad4d5a5cf5af76b86ee7162308e29b5b7 Reviewed-on: https://chromium-review.googlesource.com/554754 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#483343} [modify] https://crrev.com/1c2854bff7e7db58e3d09d691590b634df58759b/tools/perf/page_sets/system_health/expectations.py |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by charliea@chromium.org
, Jun 20 2017