New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735169 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

Rename VrShell::setWebVrModeEnabled to something more appropriate

Project Member Reported by bshe@chromium.org, Jun 20 2017

Issue description

The number of parameters of that function starts to grow. And it is no longer just enable WebVR state anymore. We should rename it to something more appropriate and use an enum to replace booleans. We can also consider add UMA to track all possible ways which entering webvr, e.g
1. click present while in VR
2. click present while in 2D
3. autopresent
4. though callback in ondisplayactivate (insert device into headset while on a webvr page)
 
Labels: VR-TD
Components: -UI>Browser>VR Internals>VR
Labels: Proj-VR
Labels: -Pri-2 -M-61 Pri-3
Cc: bshe@chromium.org
Owner: cjgrant@chromium.org
Status: Assigned (was: Available)
Biao, I am removing the only parameter besides "enabled", according to a separate bug Michael filed.  I think we should close this as well, as the method name will now be appropriate again.

Comment 5 by bshe@chromium.org, Mar 28 2018

sg. feel free to close it.
Status: WontFix (was: Assigned)
Components: Internals>XR

Sign in to add a comment