Rename VrShell::setWebVrModeEnabled to something more appropriate |
||||||
Issue descriptionThe number of parameters of that function starts to grow. And it is no longer just enable WebVR state anymore. We should rename it to something more appropriate and use an enum to replace booleans. We can also consider add UMA to track all possible ways which entering webvr, e.g 1. click present while in VR 2. click present while in 2D 3. autopresent 4. though callback in ondisplayactivate (insert device into headset while on a webvr page)
,
Jun 30 2017
,
Jul 20 2017
,
Mar 28 2018
Biao, I am removing the only parameter besides "enabled", according to a separate bug Michael filed. I think we should close this as well, as the method name will now be appropriate again.
,
Mar 28 2018
sg. feel free to close it.
,
Apr 3 2018
,
Jul 4
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ddorwin@chromium.org
, Jun 21 2017