New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735164 link

Starred by 1 user
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Jul 2017
Cc:
█ amp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Move common VR shell/UI code out of chrome/browser/android

Project Member Reported by cjgrant@chromium.org, Jun 20 2017 
The code in chrome/browser/android/vr_shell has been split into a common library, and Android/graphics-specific library.

The unit test code now relies only on the common library, and compiles for both Linux and Android.

For correctness, the common code should move out of the Android tree.  Sadrul suggested chrome/browser/vr, and Adam Parker approved of this location.  Future refactoring may relocate the code further.

The code would have moved already, but we missed M-60 branch cut.  So, the code should be moved closer to the M-61 cut, when new feature work has settled down.

Comment 1 by vollick@chromium.org, Jul 10 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e26ac32846cd9d4909393cc681ab0482d560de6

commit 4e26ac32846cd9d4909393cc681ab0482d560de6
Author: Ian Vollick <vollick@chromium.org>
Date: Tue Jul 11 14:58:21 2017

VR: Move common code to chrome/browser/vr.

NB: this is a minor revision on cjgrant@'s refactor here:
https://chromium-review.googlesource.com/c/563996/

BUG:  735164 
Change-Id: Ie79b48ece42315a4ddd86b8a2c32ab700a197799
Reviewed-on: https://chromium-review.googlesource.com/565460
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485629}
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/BUILD.gn
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/gl_browser_interface.h
[delete] https://crrev.com/9f30f25a0e29ab03c5cab295218573ce545432df/chrome/browser/android/vr_shell/test/paths.h
[delete] https://crrev.com/9f30f25a0e29ab03c5cab295218573ce545432df/chrome/browser/android/vr_shell/ui_elements/exclusive_screen_toast.h
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_controller_model.cc
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_controller_model.h
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_shell_renderer.h
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_web_contents_observer.cc
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/android/vr_shell/vr_web_contents_observer.h
[add] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/OWNERS
[add] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/PRESUBMIT.py
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/animation.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/animation.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/color_scheme.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/color_scheme.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/easing.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/easing.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/button.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/button.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/button_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/button_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/close_button_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/close_button_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/close_button_texture_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exclusive_screen_toast.cc
[add] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exclusive_screen_toast.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exclusive_screen_toast_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exclusive_screen_toast_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_prompt.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_prompt.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_prompt_backplane.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_prompt_backplane.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_prompt_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_prompt_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_prompt_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_warning_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/exit_warning_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/insecure_content_permanent_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/insecure_content_permanent_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/insecure_content_transient_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/insecure_content_transient_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/loading_indicator.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/loading_indicator.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/loading_indicator_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/loading_indicator_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/render_text_wrapper.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/render_text_wrapper.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/screen_dimmer.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/screen_dimmer.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/simple_textured_element.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/splash_screen_icon.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/splash_screen_icon.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/splash_screen_icon_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/splash_screen_icon_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/system_indicator.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/system_indicator.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/system_indicator_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/system_indicator_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/textured_element.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/textured_element.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/transience_manager.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/transience_manager.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/transience_manager_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/transient_url_bar.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/transient_url_bar.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/ui_element.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/ui_element.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/ui_element_debug_id.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/ui_element_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/ui_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/ui_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/url_bar.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/url_bar.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/url_bar_texture.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/url_bar_texture.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/font_fallback.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/font_fallback.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/fps_meter.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/fps_meter.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/fps_meter_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/gltf_asset.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/gltf_asset.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/gltf_parser.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/gltf_parser.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/gltf_parser_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/run_all_unittests.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/test/data/sample.bin
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/test/data/sample.glb
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/test/data/sample_external.gltf
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/test/data/sample_inline.gltf
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/test/paths.cc
[add] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/test/paths.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/toolbar_helper.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/toolbar_helper.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/toolbar_state.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/toolbar_state.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_browser_interface.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_element_renderer.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_input_manager.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_input_manager.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_interface.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_scene.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_scene.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_scene_manager.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_scene_manager.h
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_scene_manager_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_scene_unittest.cc
[rename] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/chrome/browser/vr/ui_unsupported_mode.h
[modify] https://crrev.com/4e26ac32846cd9d4909393cc681ab0482d560de6/testing/buildbot/gn_isolate_map.pyl

Comment 3 by vollick@chromium.org, Jul 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment