New issue
Advanced search Search tips

Issue 735158 link

Starred by 1 user
Status: Fixed
Owner:
jbroman@chromium.org
Closed: Jun 2017
Cc:
aga...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

chromium_presubmit doesn't respect Gerrit-style Tbr: header

Project Member Reported by jbroman@chromium.org, Jun 20 2017 
Instead, it treats the change as though it weren't TBR-ed. Given the suggestion to use Tbr: instead of TBR=, I'd have expected this to work. It seems to be an issue in the depot_tools presubmit support.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/dce2250d14923170c281295588e3e1ac103d6a47

commit dce2250d14923170c281295588e3e1ac103d6a47
Author: Jeremy Roman <jbroman@chromium.org>
Date: Tue Jun 20 23:10:27 2017

Presubmit: Treat changes with Gerrit-style Tbr: header as TBRed.

Bug:  735158 
Change-Id: I1444f34c84862f542909d0b70c5cdfd02394526c
Reviewed-on: https://chromium-review.googlesource.com/541638
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>

[modify] https://crrev.com/dce2250d14923170c281295588e3e1ac103d6a47/presubmit_support.py

Comment 2 by jbroman@chromium.org, Jun 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment