New issue
Advanced search Search tips

Issue 735156 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 735121



Sign in to add a comment

servo fails for nyan_kitty

Reported by jrbarnette@chromium.org, Jun 20 2017

Issue description

If you log in to a Servo V3 host serving a nyan_kitty DUT,
you find that none of them have a servod accepting connections.
Looking at servod logs, you find this exception:

2017-06-20 11:49:14,259 - SystemConfig - INFO - Loading XML config /usr/lib/python2.7/site-packages/servo/data/chromebox.xml
Traceback (most recent call last):
  File "/usr/lib/python-exec/python2.7/servod", line 9, in <module>
    load_entry_point('servo===0.0.1-8f9ffba', 'console_scripts', 'servod')()
  File "/usr/lib/python2.7/site-packages/servo/servod.py", line 529, in main
    main_function()
  File "/usr/lib/python2.7/site-packages/servo/servod.py", line 479, in main_function
    scfg.add_cfg_file(cfg_file)
  File "/usr/lib/python2.7/site-packages/servo/system_config.py", line 229, in add_cfg_file
    % (tag, name, element_str))
servo.system_config.SystemConfigError: Duplicate control ec_uart_capture without 'clobber_ok' key
<control>
    <name>ec_uart_capture</name>
    <doc>ec_uart_capture</doc>
    <params drv="uart" interface="10" map="onoff" subtype="uart_capture" />
  </control>

This is blocking repair of a large number of failed nyan_kitty devices.

 
Cc: aaboagye@chromium.org tbroch@chromium.org
Blocking: 735121

Comment 3 by tbroch@chromium.org, Jun 20 2017

Cc: hungte@chromium.org
Wondering if https://chromium-review.googlesource.com/509957 might fix?

Its committed after 8f9ffba SHA of current hdctools running in lab

gitl 8f9ffba~1...HEAD | egrep "Move the UART|8f9ffba"
6fbcea5 servo: Move the UART common controls to a separated xml file
8f9ffba chell: add INAs for WLAN and EDP power

Unfortunately I'm remote w/o access to servo to verify

Also blocker is for daisy_skate but failures there don't seem related.


Cc: ayatane@chromium.org pprabhu@chromium.org
> Wondering if https://chromium-review.googlesource.com/509957 might fix?
>
> Its committed after 8f9ffba SHA of current hdctools running in lab

Ah.  The servo version in the lab is due for an update for various
reasons, so we should expedite that.

Can someone please help confirm definitely whether the CL above will
fix the problem?  If there really is a fix in the tree, we can close
this in favor of an "Update servo in the lab" ticket.

Rescoped blocker. That blocker is just tracking the myriad ways servo repair fails in the lab that we don't have a good way of noticing yet.
 Issue 735144  has been merged into this issue.
> Can someone please help confirm definitely whether the CL above will
fix the problem?  If there really is a fix in the tree, we can close
this in favor of an "Update servo in the lab" ticket.

Yup, it works. Verified on that CL as well as the revision 4544c30. `sudo servod -b nyan_kitty` worked for both.
Cc: englab-sys-cros@google.com
Components: Infra>Client>ChromeOS
Owner: ayatane@chromium.org
Let's update servo in the lab (for servo V3 and V4) to ToT, and
see if that helps.

Lest mine eyes deceive me, looks like this should be covered by https://bugs.chromium.org/p/chromium/issues/detail?id=735610
Status: Fixed (was: Assigned)
D'oh!  I was expecting bug 735610 to be filed, but I never
saw it.  Naturally, I assumed if I didn't see it, it didn't
exist, and from that it followed (of course) that I didn't
need to _look_ for it.  :-(

Anyway:  Hooray!  Checking, I see that the nyan_kitty servo
hosts are now checking in as working.

Sign in to add a comment