New issue
Advanced search Search tips

Issue 735155 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

WebVR: headset angular velocity is invalid

Project Member Reported by klausw@chromium.org, Jun 20 2017

Issue description

The refactor https://chromium-review.googlesource.com/536475 lost a pair of parentheses in GetAngularVelocityFromPoses, so the division by epsilon_seconds was just dividing one of the matrix elements instead of the difference. This broke angular velocity calculation.
 

Comment 1 by klausw@chromium.org, Jun 20 2017

Owner: klausw@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/455a29452a85a4de9603b0d4d99373930cb20bb3

commit 455a29452a85a4de9603b0d4d99373930cb20bb3
Author: klausw <klausw@chromium.org>
Date: Tue Jun 20 20:44:40 2017

WebVR: fix angular velocity calculation for headset

The refactor https://chromium-review.googlesource.com/536475 lost a pair of
parentheses, so the division by epsilon_seconds was just dividing one of the
matrix elements instead of the difference. This broke angular velocity
calculation.

BUG= 735155 

Review-Url: https://codereview.chromium.org/2947843003
Cr-Commit-Position: refs/heads/master@{#480946}

[modify] https://crrev.com/455a29452a85a4de9603b0d4d99373930cb20bb3/device/vr/android/gvr/gvr_delegate.cc

Status: Fixed (was: Started)
Latency patch works again with this fix.
Labels: Proj-VR
Components: Blink>WebXR

Sign in to add a comment