I take it that ChromeOS sets linux_use_bundled_binutils to false. I'm afraid that I didn't account for that, sorry.

If all ChromeOS SDKs that we expect to target have a fix for this bug, it would probably be appropriate to add a "|| is_chromeos" in here somewhere.

ChromeOS SDKs have the fix for the icf section alignment issue: https://android-review.googlesource.com/#/c/368003

laszio@ rahulchaudhry@ would either of you like to send a build fix or shall I?

I'll send a CL. This probably needs a little more testing with the new binutils-2.27 as well that we're ready to upgrade to.

It looks like --icf=all got re-enabled for Chrome OS (also accidentally), but only for non-x86 architectures: https://codereview.chromium.org/2879673003

CL for re-enabling ICF on chromeos (x86/x86_64): https://chromium-review.googlesource.com/#/c/544157

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e3138745bebe1b95e32ef86dcc928d4d4bf5c7

commit 71e3138745bebe1b95e32ef86dcc928d4d4bf5c7
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Wed Jun 21 23:42:34 2017

build: allow ICF when building for chromeos.

Binutils on Chrome OS has been patched with the fix for the icf section
alignment bug (https://sourceware.org/bugzilla/show_bug.cgi?id=17704).

BUG= 735147 

Change-Id: Ibcfc6211474e1108abf9a90cef2a6b3e3ae84d0e
Reviewed-on: https://chromium-review.googlesource.com/544157
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Rahul Chaudhry <rahulchaudhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481357}
[modify] https://crrev.com/71e3138745bebe1b95e32ef86dcc928d4d4bf5c7/build/config/compiler/BUILD.gn

Closing. Please reopen it if its not fixed. Thanks!