New issue
Advanced search Search tips

Issue 735130 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

fast/events/wheel/mouse-wheel-scroll-latching.html is incredibly flaky

Project Member Reported by pdr@chromium.org, Jun 20 2017

Issue description

This test has been flaky for a long time:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&showExpectations=true&tests=fast%2Fevents%2Fwheel%2Fmouse-wheel-scroll-latching.html

The failure is:
FAIL child.scrollTop became failed to change to 100 in 0.5 seconds.

Input team, could you please triage this?
 

Comment 1 by pdr@chromium.org, Jun 20 2017

Owner: sahel@chromium.org
Status: Assigned (was: Untriaged)
Ah, this test is marked as fail but is actually passing flakily. This test needs to be rewritten.

sahel, can you take a look? The test expectations file says that this test is supposed to only pass with TouchpadAndWheelScrollLatching.

Comment 2 by pdr@chromium.org, Jun 20 2017

Components: Blink>Scroll
wheel-scroll-latching-on-scrollbar.html is also very flaky (though, marked as such) and probably needs to be rewritten too:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=wheel-scroll-latching-on-scrollbar.html
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44da1d7297d2602dc2f5775caf900a873da05b91

commit 44da1d7297d2602dc2f5775caf900a873da05b91
Author: Sahel Sharify <sahel@chromium.org>
Date: Mon Jul 31 20:32:46 2017

mouse-wheel-scroll-latching.html test rewritten

By changing the test to use promises, assertion checks happen after giving the
scroll enough time to get processed.

TEST=fast/events/wheel/mouse-wheel-scroll-latching.html,
virtual/wheelscrolllatching/fast/events/wheel/mouse-wheel-scroll-latching.html

Bug:  735130 
Change-Id: I1c13bf7eb4be88be942cea40e0bd3228ea2830d9
Reviewed-on: https://chromium-review.googlesource.com/591771
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490793}
[modify] https://crrev.com/44da1d7297d2602dc2f5775caf900a873da05b91/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/0c8943d7614bec3e70874e4d8744087d0f5b20af/third_party/WebKit/LayoutTests/fast/events/wheel/mouse-wheel-scroll-latching-expected.txt
[modify] https://crrev.com/44da1d7297d2602dc2f5775caf900a873da05b91/third_party/WebKit/LayoutTests/fast/events/wheel/mouse-wheel-scroll-latching.html

Comment 4 by sahel@chromium.org, Aug 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment