New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735117 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 735499
issue 737611
issue 738144



Sign in to add a comment

Enable/Disable cursor and shift placeholder text

Project Member Reported by newcomer@chromium.org, Jun 20 2017

Issue description

For the new launcher UI, enable/disable cursor and shift search box placeholder text whenever the user clicks on the search box, taps on the searchbox, or enters text.


 
Description: Show this description
Labels: NewLauncherUIV1
Blocking: 738144
Blocking: 737611
Blocking: 735499
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef1c07cf957e1b3ca050dec3a003c4d960cde442

commit ef1c07cf957e1b3ca050dec3a003c4d960cde442
Author: newcomer <newcomer@chromium.org>
Date: Wed Jul 12 00:38:36 2017

SearchBoxView now enables/disables cursor based on user interaction.

Updates to Integration Tests to test new searchbox behavior.
Added searchbox tests to the mus/mash filters.
Added HandleGestureEvent to TextfieldController.

Searchbox behavior added: The searchbox now has an active/inactive
state. If the searchbox is inactive and is clicked/tapped, it
activates.

UX CHANGES:
If the searchbox is Active and the user taps/clicks and the event propogates back to the AppListView, the SearchBox clears and the searchbox becomes inactive, transitioning to PEEKING or FULLSCREEN_ALL_APPS.

If the searchbox is inactive and the user taps/clicks and the event propogates back to the AppListView, the widget closes.

Also in this CL:
Mouse drag has been disabled.
Tests updated to reflect change in behavior of the app list.

BUG= 735117 

Review-Url: https://codereview.chromium.org/2952763002
Cr-Commit-Position: refs/heads/master@{#485749}

[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/search_box_view.h
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/search_result_page_view.h
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/views/controls/textfield/textfield_controller.cc
[modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/views/controls/textfield/textfield_controller.h

Status: Fixed (was: Started)
Status: ver (was: Fixed)
9807.0.0, 62.0.3176.0
Status: Verified (was: ver)

Sign in to add a comment