Enable/Disable cursor and shift placeholder text |
||||||||
Issue descriptionFor the new launcher UI, enable/disable cursor and shift search box placeholder text whenever the user clicks on the search box, taps on the searchbox, or enters text.
,
Jun 27 2017
,
Jun 29 2017
,
Jul 6 2017
,
Jul 7 2017
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef1c07cf957e1b3ca050dec3a003c4d960cde442 commit ef1c07cf957e1b3ca050dec3a003c4d960cde442 Author: newcomer <newcomer@chromium.org> Date: Wed Jul 12 00:38:36 2017 SearchBoxView now enables/disables cursor based on user interaction. Updates to Integration Tests to test new searchbox behavior. Added searchbox tests to the mus/mash filters. Added HandleGestureEvent to TextfieldController. Searchbox behavior added: The searchbox now has an active/inactive state. If the searchbox is inactive and is clicked/tapped, it activates. UX CHANGES: If the searchbox is Active and the user taps/clicks and the event propogates back to the AppListView, the SearchBox clears and the searchbox becomes inactive, transitioning to PEEKING or FULLSCREEN_ALL_APPS. If the searchbox is inactive and the user taps/clicks and the event propogates back to the AppListView, the widget closes. Also in this CL: Mouse drag has been disabled. Tests updated to reflect change in behavior of the app list. BUG= 735117 Review-Url: https://codereview.chromium.org/2952763002 Cr-Commit-Position: refs/heads/master@{#485749} [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/testing/buildbot/filters/ash_unittests_mash.filter [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/app_list_view.h [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/search_box_view.h [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/app_list/views/search_result_page_view.h [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/views/controls/textfield/textfield_controller.cc [modify] https://crrev.com/ef1c07cf957e1b3ca050dec3a003c4d960cde442/ui/views/controls/textfield/textfield_controller.h
,
Jul 21 2017
,
Aug 4 2017
9807.0.0, 62.0.3176.0
,
Aug 5 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by newcomer@chromium.org
, Jun 20 2017