New issue
Advanced search Search tips

Issue 735113 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 733655
Owner: ----
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: 2017-06-21
OS: Android
Pri: ----
Type: ----



Sign in to add a comment

blink_perf.bindings failing on 4 builders

Project Member Reported by charliea@chromium.org, Jun 20 2017

Issue description

structured-clone-long-string-serialize.html seems to be failing every time
structured-clone-long-string-deserialize.html seems to be failing most of the time

blink_perf.bindings failing on 4 builders

Builders failed on: 
- Android Nexus5 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf
- Android Nexus5X Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf
- Android Nexus6 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf
- Android One Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 20 2017

Mergedinto: 733655
Status: Duplicate (was: Available)

=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : hpayer
  Commit : 0cef7f7cf70453599887bbffd25b2e216cd63db3
  Date   : Mon Jun 12 15:58:22 2017
  Subject: [heap] Register an idle embedder garbage collection when starting incremental marking through reached marking limit.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : structured-clone-long-string-serialize/structured-clone-long-string-serialize.html

Revision                           Exit Code      N
chromium@477574                    0 +- N/A       5      good
chromium@478291                    0 +- N/A       5      good
chromium@478649                    0 +- N/A       5      good
chromium@478828                    0 +- N/A       5      good
chromium@478840                    0 +- N/A       5      good
chromium@478840,v8@1624da378e      0 +- N/A       5      good
chromium@478840,v8@0cef7f7cf7      1 +- N/A       5      bad       <--
chromium@478840,v8@711073a340      1 +- N/A       5      bad
chromium@478841                    1 +- N/A       5      bad
chromium@478842                    1 +- N/A       5      bad
chromium@478843                    1 +- N/A       5      bad
chromium@478846                    1 +- N/A       5      bad
chromium@478851                    1 +- N/A       5      bad
chromium@478873                    1 +- N/A       5      bad
chromium@478918                    1 +- N/A       5      bad
chromium@479007                    1 +- N/A       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=structured.clone.long.string.serialize.html blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976246393217774352

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5867738179829760


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adf4913b2cfb7c4dc4242d208cbf232c0bf3384c

commit adf4913b2cfb7c4dc4242d208cbf232c0bf3384c
Author: Charlie Andrews <charliea@google.com>
Date: Tue Jun 20 21:33:54 2017

Disable blink_perf.bindings long string deserialize + serialize stories

These stories are failing on Android

TBR=yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org

Bug:  735113 
Change-Id: I343e720f288e7a8b46d22a0c99f3b01768be6d45
Reviewed-on: https://chromium-review.googlesource.com/541579
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480966}
[modify] https://crrev.com/adf4913b2cfb7c4dc4242d208cbf232c0bf3384c/tools/perf/benchmarks/blink_perf.py

The NextAction date has arrived: 2017-06-21
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b12201a1e1689fff89421ec0152459b9dcfb3622

commit b12201a1e1689fff89421ec0152459b9dcfb3622
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Mon Jul 24 17:25:36 2017

Revert "Disable blink_perf.bindings long string deserialize + serialize stories"

This reverts commit adf4913b2cfb7c4dc4242d208cbf232c0bf3384c.

Reason for revert: the bug in chrome was fixed.

Original change's description:
> Disable blink_perf.bindings long string deserialize + serialize stories
> 
> These stories are failing on Android
> 
> TBR=yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org
> 
> Bug:  735113 
> Change-Id: I343e720f288e7a8b46d22a0c99f3b01768be6d45
> Reviewed-on: https://chromium-review.googlesource.com/541579
> Reviewed-by: Charlie Andrews <charliea@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Commit-Queue: Charlie Andrews <charliea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480966}

TBR=yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org,charliea@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  735113 ,736123
Change-Id: I35ab6f18191e04e2ea60836ad9b088bd847f7cc9
Reviewed-on: https://chromium-review.googlesource.com/583087
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489007}
[modify] https://crrev.com/b12201a1e1689fff89421ec0152459b9dcfb3622/tools/perf/benchmarks/blink_perf.py

Sign in to add a comment