New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735109 link

Starred by 1 user
Status: Verified
Owner:
█ sha...@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
█ rspangler@chromium.org
amstan@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: Remove 'big' and 'pit' boards

Project Member Reported by sha...@chromium.org, Jun 20 2017 
These are the last two boards using V2 host protocol. Let's nuke them, it will enable us to delete a bunch of code.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/02913eff9182de17c12eeffc9b9447d9d6e63398

commit 02913eff9182de17c12eeffc9b9447d9d6e63398
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Fri Jun 23 00:03:52 2017

cros-ec-board: Remove 'big' and 'pit' boards

These boards are being removed from cros-ec, so they need to use the
default board for ec-utils.

BUG= chromium:735109 
TEST=`emerge-nyan_big ec-utils` with pending EC patch to remove 'big'
board, verify success. Also verify ecutil arch:
`file /build/nyan_big/usr/sbin/ectool`
output: ... ELF 32-bit LSB shared object, ARM,...

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: I85971e5b6f1504deb1396e7bf39ae8441e5241cf
Reviewed-on: https://chromium-review.googlesource.com/544681
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>

[modify] https://crrev.com/02913eff9182de17c12eeffc9b9447d9d6e63398/eclass/cros-ec-board.eclass
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/b0dd82b39c57eab3a30923eb4a755172b9852f7e

commit b0dd82b39c57eab3a30923eb4a755172b9852f7e
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Fri Jun 23 00:03:52 2017

cleanup: Remove big and pit boards

Remove big and pit boards along with several now-obsolete CONFIGs /
source files.

BUG= chromium:735109 
TEST=`make buildall -j`
BRANCH=None
CQ-DEPEND=CL:544681

Change-Id: Ieb784bd36157fd1f6240cd19de6e6d12191a8097
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/540667
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/pit/board.h
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/big/ec.tasklist
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/include/pmu_tpschrome.h
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/big/gpio.inc
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/pit/board.c
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/big/board.h
[modify] https://crrev.com/b0dd82b39c57eab3a30923eb4a755172b9852f7e/power/build.mk
[modify] https://crrev.com/b0dd82b39c57eab3a30923eb4a755172b9852f7e/driver/build.mk
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/big/board.c
[modify] https://crrev.com/b0dd82b39c57eab3a30923eb4a755172b9852f7e/test/stress.c
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/pit/ec.tasklist
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/big/battery.c
[modify] https://crrev.com/b0dd82b39c57eab3a30923eb4a755172b9852f7e/common/host_command.c
[modify] https://crrev.com/b0dd82b39c57eab3a30923eb4a755172b9852f7e/include/config.h
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/driver/pmu_tps65090.c
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/pit/gpio.inc
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/big/build.mk
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/big/led.c
[modify] https://crrev.com/b0dd82b39c57eab3a30923eb4a755172b9852f7e/test/build.mk
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/board/pit/build.mk
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/driver/pmu_tps65090_powerinfo.c
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/driver/pmu_tps65090_charger.c
[delete] https://crrev.com/b3a7ede47dcf8fb8302df9c3b76921066253d22f/power/gaia.c

Comment 3 by jim.dan...@gmail.com, Jun 27 2017 

I may be misunderstanding this, but I understand that BIG is the board code for the Acer Chromebook 13 (CB5-311).

We are seeing multiple users on CBC experiencing black screen after ChromeOS updates on that device.

https://productforums.google.com/forum/#!topic/chromebook-central/I0Xo_BvUFWs;context-place=forum/chromebook-central

If this is unrelated, I will delete this post.

#CBC-RS/TC-watchlist

Comment 4 by sha...@chromium.org, Jun 27 2017 

The CL here should be a no-op, and isn't anywhere close to stable channel, so it's nearly impossible for it to be the cause of those problems. I will take a quick look to see if I can find another possible cause, or another open crbug. No need to delete your post.

Comment 5 by sha...@chromium.org, Jun 27 2017

Status: Verified (was: Untriaged)
 Issue 736807  seems to be a likely cause.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 11 2017

Labels: merge-merged-firmware-cr50-9308.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/3447ba94069963c453311e48e7ec14511c8e3329

commit 3447ba94069963c453311e48e7ec14511c8e3329
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Mon Sep 11 21:34:10 2017

cleanup: Remove big and pit boards

Remove big and pit boards along with several now-obsolete CONFIGs /
source files.

 Conflicts:
	board/big/board.h
	board/pit/board.h
	include/config.h

BUG= chromium:735109 
TEST=`make buildall -j`
BRANCH=None
CQ-DEPEND=CL:544681

Change-Id: Ieb784bd36157fd1f6240cd19de6e6d12191a8097
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/540667
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
(cherry picked from commit b0dd82b39c57eab3a30923eb4a755172b9852f7e)
Reviewed-on: https://chromium-review.googlesource.com/660889
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>

[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/pit/board.h
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/big/ec.tasklist
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/include/pmu_tpschrome.h
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/big/gpio.inc
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/pit/board.c
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/big/board.h
[modify] https://crrev.com/3447ba94069963c453311e48e7ec14511c8e3329/power/build.mk
[modify] https://crrev.com/3447ba94069963c453311e48e7ec14511c8e3329/driver/build.mk
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/big/board.c
[modify] https://crrev.com/3447ba94069963c453311e48e7ec14511c8e3329/test/stress.c
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/pit/ec.tasklist
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/big/battery.c
[modify] https://crrev.com/3447ba94069963c453311e48e7ec14511c8e3329/common/host_command.c
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/driver/pmu_tps65090.c
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/pit/gpio.inc
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/big/build.mk
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/big/led.c
[modify] https://crrev.com/3447ba94069963c453311e48e7ec14511c8e3329/test/build.mk
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/board/pit/build.mk
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/driver/pmu_tps65090_powerinfo.c
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/driver/pmu_tps65090_charger.c
[delete] https://crrev.com/56fac9fcd88025984d91fb1e7cbf9b7ecfb0b552/power/gaia.c
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2017

Labels: merge-merged-firmware-cr50-release-9308.25.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/6b62ff6db9abdd349e8840dc5cc8738907db2ea9

commit 6b62ff6db9abdd349e8840dc5cc8738907db2ea9
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Thu Sep 14 19:07:06 2017

cleanup: Remove big and pit boards

Remove big and pit boards along with several now-obsolete CONFIGs /
source files.

 Conflicts:
	board/big/board.h
	board/pit/board.h
	include/config.h

BUG= chromium:735109 
TEST=`make buildall -j`
BRANCH=None
CQ-DEPEND=CL:544681

Change-Id: Ieb784bd36157fd1f6240cd19de6e6d12191a8097
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/540667
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
(cherry picked from commit b0dd82b39c57eab3a30923eb4a755172b9852f7e)
Reviewed-on: https://chromium-review.googlesource.com/660889
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
(cherry picked from commit 3447ba94069963c453311e48e7ec14511c8e3329)
Reviewed-on: https://chromium-review.googlesource.com/666537

[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/pit/board.h
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/big/ec.tasklist
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/include/pmu_tpschrome.h
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/big/gpio.inc
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/pit/board.c
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/big/board.h
[modify] https://crrev.com/6b62ff6db9abdd349e8840dc5cc8738907db2ea9/power/build.mk
[modify] https://crrev.com/6b62ff6db9abdd349e8840dc5cc8738907db2ea9/driver/build.mk
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/big/board.c
[modify] https://crrev.com/6b62ff6db9abdd349e8840dc5cc8738907db2ea9/test/stress.c
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/pit/ec.tasklist
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/big/battery.c
[modify] https://crrev.com/6b62ff6db9abdd349e8840dc5cc8738907db2ea9/common/host_command.c
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/driver/pmu_tps65090.c
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/pit/gpio.inc
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/big/build.mk
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/big/led.c
[modify] https://crrev.com/6b62ff6db9abdd349e8840dc5cc8738907db2ea9/test/build.mk
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/board/pit/build.mk
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/driver/pmu_tps65090_powerinfo.c
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/driver/pmu_tps65090_charger.c
[delete] https://crrev.com/17b786ded098cfb9aeed9ae92af1122039e07df1/power/gaia.c
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 15 2017

Labels: merge-merged-firmware-cr50-9308.24.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/c478358beb8778282c72fa5645bd3cf210310b5f

commit c478358beb8778282c72fa5645bd3cf210310b5f
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Fri Sep 15 22:31:35 2017

cleanup: Remove big and pit boards

Remove big and pit boards along with several now-obsolete CONFIGs /
source files.

 Conflicts:
	board/big/board.h
	board/pit/board.h
	include/config.h

BUG= chromium:735109 
TEST=`make buildall -j`
BRANCH=None
CQ-DEPEND=CL:544681

Change-Id: Ieb784bd36157fd1f6240cd19de6e6d12191a8097
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/540667
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
(cherry picked from commit b0dd82b39c57eab3a30923eb4a755172b9852f7e)
Reviewed-on: https://chromium-review.googlesource.com/660889
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
(cherry picked from commit 3447ba94069963c453311e48e7ec14511c8e3329)
Reviewed-on: https://chromium-review.googlesource.com/669050

[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/pit/board.h
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/big/ec.tasklist
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/include/pmu_tpschrome.h
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/big/gpio.inc
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/pit/board.c
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/big/board.h
[modify] https://crrev.com/c478358beb8778282c72fa5645bd3cf210310b5f/power/build.mk
[modify] https://crrev.com/c478358beb8778282c72fa5645bd3cf210310b5f/driver/build.mk
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/big/board.c
[modify] https://crrev.com/c478358beb8778282c72fa5645bd3cf210310b5f/test/stress.c
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/pit/ec.tasklist
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/big/battery.c
[modify] https://crrev.com/c478358beb8778282c72fa5645bd3cf210310b5f/common/host_command.c
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/driver/pmu_tps65090.c
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/pit/gpio.inc
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/big/build.mk
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/big/led.c
[modify] https://crrev.com/c478358beb8778282c72fa5645bd3cf210310b5f/test/build.mk
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/board/pit/build.mk
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/driver/pmu_tps65090_powerinfo.c
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/driver/pmu_tps65090_charger.c
[delete] https://crrev.com/483842991ab4deba68ba6130810f86b995f67205/power/gaia.c
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 30 2017

Labels: merge-merged-firmware-servo-9040.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/ef0d3c8a5f3b6ad6a74b9892269cb4a90e281967

commit ef0d3c8a5f3b6ad6a74b9892269cb4a90e281967
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Mon Oct 30 17:04:19 2017

cleanup: Remove big and pit boards

Remove big and pit boards along with several now-obsolete CONFIGs /
source files.

BUG= chromium:735109 
TEST=`make buildall -j`
BRANCH=None
CQ-DEPEND=CL:544681

Change-Id: Ieb784bd36157fd1f6240cd19de6e6d12191a8097
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/540667
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/739985

[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/pit/board.h
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/big/ec.tasklist
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/include/pmu_tpschrome.h
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/big/gpio.inc
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/pit/board.c
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/big/board.h
[modify] https://crrev.com/ef0d3c8a5f3b6ad6a74b9892269cb4a90e281967/power/build.mk
[modify] https://crrev.com/ef0d3c8a5f3b6ad6a74b9892269cb4a90e281967/driver/build.mk
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/big/board.c
[modify] https://crrev.com/ef0d3c8a5f3b6ad6a74b9892269cb4a90e281967/test/stress.c
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/pit/ec.tasklist
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/big/battery.c
[modify] https://crrev.com/ef0d3c8a5f3b6ad6a74b9892269cb4a90e281967/common/host_command.c
[modify] https://crrev.com/ef0d3c8a5f3b6ad6a74b9892269cb4a90e281967/include/config.h
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/driver/pmu_tps65090.c
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/pit/gpio.inc
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/big/build.mk
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/big/led.c
[modify] https://crrev.com/ef0d3c8a5f3b6ad6a74b9892269cb4a90e281967/test/build.mk
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/board/pit/build.mk
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/driver/pmu_tps65090_powerinfo.c
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/driver/pmu_tps65090_charger.c
[delete] https://crrev.com/9adc8cd6645a105f4587c631b89cab7f08c76ea9/power/gaia.c
►

Sign in to add a comment