New issue
Advanced search Search tips

Issue 735100 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Support policy for extensions

Project Member Reported by ljusten@chromium.org, Jun 20 2017

Issue description

Figure out what to do to support policy for extensions.
 
Components: Enterprise

Comment 2 by tnagel@chromium.org, Jun 20 2017

Labels: -M-61
Labels: -Pri-1 M-61 Pri-2

Comment 4 by tnagel@chromium.org, Jul 12 2017

Labels: -M-61
Labels: M-62

Comment 6 by dskaram@google.com, Jul 28 2017

Labels: -Pri-2 Pri-1

Comment 7 by tnagel@chromium.org, Jul 31 2017

Cc: -tnagel@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3

commit 7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Sep 27 01:24:08 2017

authpolicy: Get extension policy from GPO

Policy for Chrome extensions allows Active Directory admins to set
policy for extensions like the Managed Bookmarks sample extension or,
more importantly, the Certificate Enrollment for Chrome OS extension.

Editing extension policy requires an ADMX template for each extension.
The policy is stored in GPO similar to how user and device policy is
stored, but it uses a slightly different registry key layout. This CL
reads policy for all extensions (keyed by the 32-byte extension ID)
and converts it to a list of (extension ID, JSON blob).

Extension policy is going to be stored similarly to user and device
policy by sending it to Session Manager. Right now, the JSON blobs
are thrown away, see AuthPolicy::StorePolicy. In an upcoming CL,
Session Manager will be able to accept and store extension policy.
After that, Chrome will load extension policy from Session Manager
and set it.

BUG= chromium:735100 
TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy
     Tested policy fetch on device.

Change-Id: I39e4bf3cc88a63e5fdf2339d6a2ecd19b25a4f3f
Reviewed-on: https://chromium-review.googlesource.com/666623
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/device_policy_encoder.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/preg_policy_encoder.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/authpolicy.gyp
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/policy_encoder_helper.h
[add] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/extension_policy_encoder.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/samba_interface.h
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/preg_policy_encoder_unittest.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/authpolicy.h
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/samba_interface.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/proto/authpolicy_containers.proto
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/authpolicy_parser_main.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/user_policy_encoder.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/policy_encoder_helper.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/policy_encoder_test_base.h
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/preg_policy_writer.h
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/authpolicy.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/preg_policy_encoder.h
[add] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/extension_policy_encoder_unittest.cc
[modify] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/preg_policy_writer.cc
[add] https://crrev.com/7e0f7af5d047babdf153b1a2dae1a0e79a1b65c3/authpolicy/policy/extension_policy_encoder.h

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/430b183f58b2da0614a020594ca6ab479dce8453

commit 430b183f58b2da0614a020594ca6ab479dce8453
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Dec 11 13:32:15 2017

authpolicy: Send extension policy to Session Manager

Policy for Chrome extensions allows Active Directory admins to set
policy for extensions like the Managed Bookmarks sample extension or,
more importantly, the Certificate Enrollment for Chrome OS extension.

In CL:666623 extension policy was parsed from Active Directory group
policy objects and written to an internal data structure, but not used
yet. This CL sends extension policy to Session Manager along with the
user or device policy. In a future CL, Chrome will load extension
policy from Session Manager and set it. This will finish this feature.

This CL also switches authpolicy over to the new StorePolicyEx
interface.

BUG= chromium:735100 
TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy

Change-Id: Idecf5e783b2cd88a08c1c23688e21fd29c0e8ffd
Reviewed-on: https://chromium-review.googlesource.com/719011
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/430b183f58b2da0614a020594ca6ab479dce8453/authpolicy/policy/preg_policy_encoder_unittest.cc
[modify] https://crrev.com/430b183f58b2da0614a020594ca6ab479dce8453/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/430b183f58b2da0614a020594ca6ab479dce8453/authpolicy/authpolicy.h
[modify] https://crrev.com/430b183f58b2da0614a020594ca6ab479dce8453/authpolicy/policy/preg_policy_writer.h
[modify] https://crrev.com/430b183f58b2da0614a020594ca6ab479dce8453/authpolicy/authpolicy.cc
[modify] https://crrev.com/430b183f58b2da0614a020594ca6ab479dce8453/authpolicy/policy/preg_policy_writer.cc

Labels: -M-62
Labels: M-66
Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11cf45feb84c7784e6050c418f13b4b953c88f04

commit 11cf45feb84c7784e6050c418f13b4b953c88f04
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Mar 29 15:55:42 2018

Improve extension ADMX generator

Improves generate_extension_admx.py, which consumes an extension
schema.json file and produces ADMX templates.
- Handle 'object' type schema fields, which add a sub-category to the
  ADMX.
- Handle 'number' type schema fields. Those are floating point numbers,
  but unfortunately ADMX doesn't support floats, so we fall back to ints
  for now. In the long run, maybe we can use strings and handle string
  to double conversion in the pipeline (schema validation, json
  parsing).
- Adds fallbacks for title (falls back to policy name) and description
  (falls back to no description at all).

BUG= chromium:735100 
TEST=Ran it on json schema of Chrome OS certificate extension

Change-Id: Ic02debe4c727150157d124bec9e6004bedcf4815
Reviewed-on: https://chromium-review.googlesource.com/981151
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546848}
[modify] https://crrev.com/11cf45feb84c7784e6050c418f13b4b953c88f04/components/policy/tools/generate_extension_admx.py

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fccc9de936d7b22b4ee9b06947a8d8c783040a2

commit 5fccc9de936d7b22b4ee9b06947a8d8c783040a2
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Apr 05 16:18:41 2018

Refactor ActiveDirectoryPolicyManager

Created specializations of ActiveDirectoryPolicyManager for user and
device policy instead of handling everything inside the base class.
The differences between user and device policy are still small right
now, but they're only going to grow (as I noticed while working on
policy for extensions), so it's important to do the split early on.

Keeps all ActiveDirectory*PolicyManagers in one file to simplify
reviews, but they are going to be moved to their own files in an
upcoming CL.

BUG= chromium:735100 
TEST=out/Release/unit_tests --gtest_filter=*ActiveDirectoryPolicyManagerTest.*
     Tested on device

Change-Id: I55b5d8cfb3646058510729f2028a6b6aa2f9584e
Reviewed-on: https://chromium-review.googlesource.com/972482
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548444}
[modify] https://crrev.com/5fccc9de936d7b22b4ee9b06947a8d8c783040a2/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
[modify] https://crrev.com/5fccc9de936d7b22b4ee9b06947a8d8c783040a2/chrome/browser/chromeos/policy/active_directory_policy_manager.h
[modify] https://crrev.com/5fccc9de936d7b22b4ee9b06947a8d8c783040a2/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc
[modify] https://crrev.com/5fccc9de936d7b22b4ee9b06947a8d8c783040a2/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/5fccc9de936d7b22b4ee9b06947a8d8c783040a2/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2

commit bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Apr 12 13:27:38 2018

Refactor CloudPolicyValidator

Refactored CloudPolicyValidator so that the base class doesn't expect
the policy_value() to be a protobuf. This is a preparation for the
support of extension policy for Active Directory managed devices, where
the policy_value() is a JSON blob.

Also removed the static Create methods. There's no reason to have them
as one can use the constructor directly. The rest is clang format.

BUG= chromium:735100 
TEST=Trybots

Change-Id: Ic952c2cd00e945910f62d0ad08839282818d1d1e
Reviewed-on: https://chromium-review.googlesource.com/1002654
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550169}
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/chrome/browser/chromeos/policy/device_local_account_policy_store.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/chrome/browser/chromeos/settings/session_manager_operation.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/components/policy/core/common/cloud/cloud_policy_validator.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/components/policy/core/common/cloud/cloud_policy_validator.h
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/components/policy/core/common/cloud/component_cloud_policy_store.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/components/policy/core/common/cloud/machine_level_user_cloud_policy_store.cc
[modify] https://crrev.com/bc2ee55f2a9a3a4c45ccb4c3d50e8f78bf4977a2/components/policy/core/common/cloud/user_cloud_policy_store_base.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2699d746b3b110bea6ad45a5c111e6b68d2764d6

commit 2699d746b3b110bea6ad45a5c111e6b68d2764d6
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Apr 12 22:22:23 2018

authpolicy: Add component ID and machine_name to PolicyData

Component id is going to be used during component policy validation.
Machine name is useful for variable replacement, so the machine name
is available in UserActiveDirectoryPolicyManager.

BUG= chromium:829279 , chromium:735100 
TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy

Change-Id: Ia4adf15ecef7f72beb3cc27ad4a773f375abd834
Reviewed-on: https://chromium-review.googlesource.com/1005036
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[modify] https://crrev.com/2699d746b3b110bea6ad45a5c111e6b68d2764d6/authpolicy/authpolicy.cc
[modify] https://crrev.com/2699d746b3b110bea6ad45a5c111e6b68d2764d6/authpolicy/authpolicy_unittest.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c1f712825a8f13d56df963b8451c346c9ec7374

commit 7c1f712825a8f13d56df963b8451c346c9ec7374
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Apr 30 07:31:23 2018

Refactor PolicyBuilder

Renames ComponentPolicyBuilder to ComponentCloudPolicyBuilder and adds
StringPolicyBuilder == ComponentActiveDirectoryPolicyBuilder, which
has a string payload instead of a protobuf payload. Active Directory
managed Chrome OS devices are going to use that for tests.

BUG= chromium:735100 
TEST=Tryjobs

Change-Id: Id1f0591559d70d7e596e756d8ca5a8a588499a72
Reviewed-on: https://chromium-review.googlesource.com/1032559
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554705}
[modify] https://crrev.com/7c1f712825a8f13d56df963b8451c346c9ec7374/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/7c1f712825a8f13d56df963b8451c346c9ec7374/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
[modify] https://crrev.com/7c1f712825a8f13d56df963b8451c346c9ec7374/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc
[modify] https://crrev.com/7c1f712825a8f13d56df963b8451c346c9ec7374/components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc
[modify] https://crrev.com/7c1f712825a8f13d56df963b8451c346c9ec7374/components/policy/core/common/cloud/policy_builder.cc
[modify] https://crrev.com/7c1f712825a8f13d56df963b8451c346c9ec7374/components/policy/core/common/cloud/policy_builder.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f665a859d4b9fbebcc9c31fd58e20c647993f9dc

commit f665a859d4b9fbebcc9c31fd58e20c647993f9dc
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed May 16 08:48:39 2018

Add ComponentActiveDirectoryPolicyRetriever

Part 1 of Active Directory extension policy support. This CL adds a
ComponentActiveDirectoryPolicyRetriever class that is used to retrieve
a set of component policy blobs from Session Manager, e.g. policy for
N different extensions. This class will be used together with a
ComponentActiveDirectoryPolicyService to provide extension policy to the
two ActiveDirectoryPolicyManager instances.

BUG=chromium:784595
TEST=unit_tests --gtest_filter=ComponentActiveDirectoryPolicyRetriever*

Change-Id: I443e8a5f388207894ee022a7d2ab93dac57aae2b
Reviewed-on: https://chromium-review.googlesource.com/1032740
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559017}
[modify] https://crrev.com/f665a859d4b9fbebcc9c31fd58e20c647993f9dc/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/f665a859d4b9fbebcc9c31fd58e20c647993f9dc/chrome/browser/chromeos/policy/component_active_directory_policy_retriever.cc
[add] https://crrev.com/f665a859d4b9fbebcc9c31fd58e20c647993f9dc/chrome/browser/chromeos/policy/component_active_directory_policy_retriever.h
[add] https://crrev.com/f665a859d4b9fbebcc9c31fd58e20c647993f9dc/chrome/browser/chromeos/policy/component_active_directory_policy_retriever_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9006a26a7e2bd39b5eb9812b7a78b380b076d77e

commit 9006a26a7e2bd39b5eb9812b7a78b380b076d77e
Author: Lutz Justen <ljusten@chromium.org>
Date: Fri May 18 09:33:42 2018

Add ComponentActiveDirectoryPolicyService

Part 2 of Active Directory extension policy support. This CL adds a
ComponentActiveDirectoryPolicyService class that is responsible for
fetching and parsing component policy, performing type conversions and
validating schema. To fetch policy it uses the ComponentActiveDirectory-
PolicyRetriever class introduced in part 1. In part 3 this class will be
hooked up with the ActiveDirectoryPolicyManager instances.

BUG=chromium:784595
TEST=unit_tests --gtest_filter=ComponentActiveDirectoryPolicyService*

Change-Id: Ib601706c6efdb2017108384687e36fbff7fae98c
Reviewed-on: https://chromium-review.googlesource.com/1057620
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559845}
[modify] https://crrev.com/9006a26a7e2bd39b5eb9812b7a78b380b076d77e/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9006a26a7e2bd39b5eb9812b7a78b380b076d77e/chrome/browser/chromeos/policy/component_active_directory_policy_retriever_unittest.cc
[add] https://crrev.com/9006a26a7e2bd39b5eb9812b7a78b380b076d77e/chrome/browser/chromeos/policy/component_active_directory_policy_service.cc
[add] https://crrev.com/9006a26a7e2bd39b5eb9812b7a78b380b076d77e/chrome/browser/chromeos/policy/component_active_directory_policy_service.h
[add] https://crrev.com/9006a26a7e2bd39b5eb9812b7a78b380b076d77e/chrome/browser/chromeos/policy/component_active_directory_policy_service_unittest.cc
[modify] https://crrev.com/9006a26a7e2bd39b5eb9812b7a78b380b076d77e/components/policy/core/common/registry_dict.cc
[modify] https://crrev.com/9006a26a7e2bd39b5eb9812b7a78b380b076d77e/components/policy/core/common/registry_dict.h


The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb

commit a1dae360d82cb7e7e1bce648c22e19d4818eb9fb
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu May 24 14:33:00 2018

Add support for Active Directory extension policy

Part 3 of Active Directory extension policy support. This CL wires
ComponentActiveDirectoryPolicyService up with ActiveDirectoryPolicyManager
and unlocks extension policy for Active Directory managed Chrome OS
devices (Chromad). It is the final missing link to enable extension
policy for Chromad. You can now do all the crazy things you've always
been dreaming of like using the Certificate Enrollment for Chrome OS
extension to mint client certificates in a PKI environment based off
ADCS.

BUG=chromium:784595
TEST=browser_tests --gtest_filter=ComponentActiveDirectory*

Change-Id: I27aaba07aff9460779b18a01cc88cc338a78f381
Reviewed-on: https://chromium-review.googlesource.com/1057621
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561497}
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/login/users/chrome_user_manager_util.cc
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/policy/active_directory_policy_manager.h
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[add] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/policy/component_active_directory_policy_browsertest.cc
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/policy/component_active_directory_policy_retriever.cc
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/policy/component_active_directory_policy_retriever.h
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/chromeos/policy/component_active_directory_policy_service.h
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/browser/policy/schema_registry_service_factory.cc
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/test/BUILD.gn
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/test/data/extensions/api_test/README.txt
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/chrome/test/data/extensions/managed_extension/background.js
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/components/policy/core/common/policy_bundle.h
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/components/policy/core/common/schema_map.h
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/components/user_manager/user_names.cc
[modify] https://crrev.com/a1dae360d82cb7e7e1bce648c22e19d4818eb9fb/components/user_manager/user_names.h

Status: Fixed (was: Started)
The last 3 CLs CL:1032740, CL:1057620 and CL:1057621 had the wrong bug ID. I moved them over from https://crbug.com/784595.
Status: Verified (was: Fixed)
Verified fixed, tested the following policies for extensions:

ExtensionInstallBlacklist
ExtensionInstallWhitelist
ExtensionInstallForcelist
ExtensionInstallSources
ExtensionAllowedTypes
ExtensionSettings

No issues, policies fetched and applied as expected.

Chrome OS: 10804.0.0
Chrome: 69.0.3464.0
Deice: Robo

Sign in to add a comment