Issue metadata
Sign in to add a comment
|
Ads settings in Content Settings does not show the updated value (only through searching in Content Settings) |
||||||||||||||||||||||||||
Issue descriptionSteps: - chrome://settings - search for Ads - go to content settings - change the value from blocked to allowed - press the back arrow - it still shows as blocked This works fine when instead of search and going to content settings, we go directly from advanced to content settings.
,
Jun 20 2017
Also, adding that the value does not show as updated on going through the back arrow but when I open another tab with the Ads setting , it shows the value updated to 'allowed'.
,
Jun 20 2017
,
Jun 23 2017
,
Nov 10 2017
,
Feb 18 2018
,
Mar 12 2018
,
Mar 12 2018
Removing from owner as I'm not actively looking at it.
,
Mar 13 2018
dschuyler: this sounds like a site settings issue. Can you help triage?
,
Mar 28 2018
,
Apr 3 2018
,
Apr 3 2018
,
Apr 3 2018
IIUC, this bug is happening because of what is described at https://bugs.chromium.org/p/chromium/issues/detail?id=711156.
,
Apr 3 2018
@dpapad, that's exactly the case. I handled the case for the site settings page here https://chromium-review.googlesource.com/c/chromium/src/+/992886 I'll take a look at the 711156 and see if I can generalize the solution. Otherwise we'll need to partially redo the search wherever we notice this issue.
,
Apr 3 2018
Another approach which has been discussed in the past is to stop changing the the toggle's label, such that the label always displays the exact same text whethe on or off. This would also alleviate the problem (as well as addressing a different UX concern about changing labels being confusing). I think we have a bug for the latter (will look for it).
,
Apr 3 2018
We could have fixed text in certain cases, but that could be considered a seperate problem from stale searches that need a partial refresh. Another approach could be to tag dynamic text to be excluded from search altogeher.
,
Apr 3 2018
Regarding marking dynamic text with no-search, there is some precedent for it. See https://codereview.chromium.org/2808403009. I think it might be fine for the Site Settings secondary rows (meaning it would not reduce the chances of a user finding what they are looking for when they query).
,
Apr 5 2018
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by csharrison@chromium.org
, Jun 20 2017Components: UI>Browser>SiteSettings