New issue
Advanced search Search tips

Issue 735092 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 711156
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Ads settings in Content Settings does not show the updated value (only through searching in Content Settings)

Project Member Reported by shivanisha@chromium.org, Jun 20 2017

Issue description

Steps:

- chrome://settings
- search for Ads
- go to content settings
- change the value from blocked to allowed
- press the back arrow
- it still shows as blocked

This works fine when instead of search and going to content settings, we go directly from  advanced to content settings.
 
Cc: tommycli@chromium.org
Components: UI>Browser>SiteSettings
No idea why this is happening :/ adding tommycli and the SiteSettings component to see if anyone has seen this type of behavior before.

Last time there was a UI regression here I (essentially) banged my head on privacy_page.html until things worked.
Also, adding that the value does not show as updated on going through the back arrow but when I open another tab with the Ads setting , it shows the value updated to 'allowed'.
Description: Show this description
Cc: msramek@chromium.org
Components: Privacy

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 6 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Components: UI>Browser>AdFilter
Cc: csharrison@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Removing from owner as I'm not actively looking at it.

Comment 9 by raymes@chromium.org, Mar 13 2018

Cc: patricia...@chromium.org
Components: UI>Settings
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
dschuyler: this sounds like a site settings issue. Can you help triage? 

Comment 10 by aee@chromium.org, Mar 28 2018

Cc: aee@chromium.org

Comment 11 by aee@chromium.org, Apr 3 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org

Comment 12 by aee@chromium.org, Apr 3 2018

Status: Started (was: Assigned)
IIUC, this bug is happening because of what is described at https://bugs.chromium.org/p/chromium/issues/detail?id=711156.

Comment 14 by aee@chromium.org, Apr 3 2018

@dpapad, that's exactly the case.

I handled the case for the site settings page here https://chromium-review.googlesource.com/c/chromium/src/+/992886

I'll take a look at the 711156 and see if I can generalize the solution. Otherwise we'll need to partially redo the search wherever we notice this issue.

Another approach which has been discussed in the past is to stop changing the the toggle's label, such that the label always displays the exact same text whethe on or off.

This would also alleviate the problem (as well as addressing a different UX concern about changing labels being confusing). I think we have a bug for the latter (will look for it).

Comment 16 by aee@chromium.org, Apr 3 2018

We could have fixed text in certain cases, but that could be considered a seperate problem from stale searches that need a partial refresh.

Another approach could be to tag dynamic text to be excluded from search altogeher.

Regarding marking dynamic text with no-search, there is some precedent for it. See https://codereview.chromium.org/2808403009. I think it might be fine for the Site Settings secondary rows (meaning it would not reduce the chances of a user finding what they are looking for when they query).

Comment 18 by aee@chromium.org, Apr 5 2018

Mergedinto: 711156
Status: Duplicate (was: Started)

Sign in to add a comment