Issue metadata
Sign in to add a comment
|
Sad Tab buttons overlap error text until the window is resized |
||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3136.0 OS: macOS I broke this in r480509, working on a fix now.
,
Jun 20 2017
,
Jun 21 2017
,
Jun 21 2017
Issue 735339 has been merged into this issue.
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f162a9c56a5457c2a2770d1d3e20a5cc560c3e02 commit f162a9c56a5457c2a2770d1d3e20a5cc560c3e02 Author: Sidney San MartÃn <sdy@chromium.org> Date: Fri Jun 23 20:48:08 2017 Fix overlapping text on the Sad Tab. Resizing the window makes this go away, so it's just an issue with initial layout. TBR=sdy@chromium.org (cherry picked from commit 097282c9bace63f4362f882bcdfd2a6fef8c1910) Bug: 735089 Change-Id: I84b4fba971dd26f79389f90804fd21b92f8031ca Reviewed-on: https://chromium-review.googlesource.com/541058 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martin <sdy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#480890} Reviewed-on: https://chromium-review.googlesource.com/546777 Reviewed-by: Sidney San Martin <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#451} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/f162a9c56a5457c2a2770d1d3e20a5cc560c3e02/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm
,
Jun 23 2017
(Merge approval is in issue 732864 , sorry for not tagging the commit properly.)
,
Jun 27 2017
Tested the issue on Chrome Dev# 61.0.3141.0 using Mac OS X 10.12.5. Below are the steps followed -- (i) Opened New Tab and navigated to chrome://crash and observed Aw Snap page. (ii) Reloaded and again navigated to chrome://crash page within 10 seconds and observed the tips (as in the screenshot). As per Comments 21, 22 & 23 under Bug Id - "https://bugs.chromium.org/p/chromium/issues/detail?id=732864" adding TE-Verified labels. Thank You.
,
Jun 28 2017
Tested the issue on Mac OS 10.12.5 using chrome latest Beta M60 - 60.0.3112.50 by following steps mentioned in comment #7 and As per Comments 21, 22 & 23 under Bug Id - "https://bugs.chromium.org/p/chromium/issues/detail?id=732864" . Observed that sad main screen displaying as expected. Hence adding TE-Verified label. Please find the screen shot for reference. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by sdy@chromium.org
, Jun 20 2017