New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 735065 link

Starred by 1 user
Status: Verified
Owner:
mvanouwe...@chromium.org
Closed: Jun 2017
Cc:
█ nepper@chromium.org
fi...@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Only one row of icons in Zine on Chrome Home

Project Member Reported by rachelis@chromium.org, Jun 20 2017 
It seems like we only have 1 row of icons in Chrome Home, but I *think* we should have 2.

Comment 1 by rachelis@chromium.org, Jun 20 2017

Components: UI>Browser>NewTabPage
Labels: zine-ux

Comment 2 by mvanouwe...@chromium.org, Jun 20 2017

Labels: M-61 zine-client
Owner: mvanouwe...@chromium.org
Status: Assigned (was: Untriaged)
When the Chrome Home sheet is pulled up halfway, there is very little space. Let's discuss in the next UX sync whether 2 rows is really what we want.

Comment 3 by mvanouwe...@chromium.org, Jun 22 2017 

Attaching screenshots of Chrome Home half and completely open.
screenshot-ZX1G427RJN-20170622T123611.png
559 KB View Download
screenshot-ZX1G427RJN-20170622T123918.png
977 KB View Download

Comment 4 by mvanouwe...@chromium.org, Jun 22 2017

Status: Started (was: Assigned)

Comment 5 by mvanouwe...@chromium.org, Jun 22 2017 

We discussed this during the UX sync meeting, and really Rachel meant this to be 2 rows all along. No one felt strongly about using 1 row, so 2 it is.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f94a806ba1b6108745375cde099fd402c536281d

commit f94a806ba1b6108745375cde099fd402c536281d
Author: mvanouwerkerk <mvanouwerkerk@chromium.org>
Date: Thu Jun 22 17:25:38 2017

Use two tile rows in Chrome Home.

BUG= 735065 

Review-Url: https://codereview.chromium.org/2953083002
Cr-Commit-Position: refs/heads/master@{#481581}

[modify] https://crrev.com/f94a806ba1b6108745375cde099fd402c536281d/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java

Comment 7 by mvanouwe...@chromium.org, Jun 22 2017

Status: Fixed (was: Started)

Comment 8 by krav...@chromium.org, Jun 27 2017 

Verified in M61-61.0.3142.0 build
twotiles.png
142 KB View Download

Comment 9 by krav...@chromium.org, Jun 27 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment