finalize_bundle.py and import_bundle.py have different expectation of compressed bundle's folder layout |
||
Issue description
The tar command of finalize_bundle.py will create folder layout in tarball like below:
factory_bundle_board_2017xxxx_evt1/
release_image/
test_image/
...
But when import_bundle.py is called with the tarball, it expects extracted folder layout in tmpdir would be
release_image/
test_image/
...
Therefore the import_bundle.py will fail to import tarball generated by finalize_bundle.py because there is no candidate for resource.PayloadTypeNames.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/1ed96ece51488b01fbaba0b3e757d7516aa93714 commit 1ed96ece51488b01fbaba0b3e757d7516aa93714 Author: Marco Chen <marcochen@chromium.org> Date: Wed Jun 21 08:03:00 2017 tools: finalize_bundle: Remove parent directory in generated tarball. To keep the same expectation of folder layout between finalize_bundle.py and import_bundle.py. BUG= chromium:735054 TEST=manually do finalize_bundle and import_bundle of umpire. Change-Id: I264dbb7ad7e11c5aa21b9b837af62d3ae1e4b2d4 Reviewed-on: https://chromium-review.googlesource.com/541239 Commit-Ready: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> Reviewed-by: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/1ed96ece51488b01fbaba0b3e757d7516aa93714/py/tools/finalize_bundle.py
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/1ed96ece51488b01fbaba0b3e757d7516aa93714 commit 1ed96ece51488b01fbaba0b3e757d7516aa93714 Author: Marco Chen <marcochen@chromium.org> Date: Wed Jun 21 08:03:00 2017 tools: finalize_bundle: Remove parent directory in generated tarball. To keep the same expectation of folder layout between finalize_bundle.py and import_bundle.py. BUG= chromium:735054 TEST=manually do finalize_bundle and import_bundle of umpire. Change-Id: I264dbb7ad7e11c5aa21b9b837af62d3ae1e4b2d4 Reviewed-on: https://chromium-review.googlesource.com/541239 Commit-Ready: Marco Chen <marcochen@chromium.org> Tested-by: Marco Chen <marcochen@chromium.org> Reviewed-by: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/1ed96ece51488b01fbaba0b3e757d7516aa93714/py/tools/finalize_bundle.py
,
Jun 27 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by marcochen@chromium.org
, Jun 20 2017Status: Started (was: Untriaged)