New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 735049 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

CSP CSPSourceList Check failed: !allow_star || (!allow_self && sources.empty()).

Project Member Reported by arthurso...@chromium.org, Jun 20 2017

Issue description

Navigating to https://www.facebook.com now crashes the renderer in a DCHECK.

[1:1:0620/162057.099950:FATAL:csp_source_list.cc(32)] Check failed: !allow_star || (!allow_self && sources.empty()). 
#0 0x7f6af5e7528b base::debug::StackTrace::StackTrace()
#1 0x7f6af5e73f8c base::debug::StackTrace::StackTrace()
#2 0x7f6af5ee8473 logging::LogMessage::~LogMessage()
#3 0x7f6aee503a61 content::CSPSourceList::CSPSourceList()
#4 0x7f6af0254a78 content::BuildCSPSourceList()
#5 0x7f6af0254ae9 content::BuildCSPDirective()
#6 0x7f6af0254be0 content::BuildContentSecurityPolicy()
#7 0x7f6af03f7c7a content::RenderFrameImpl::DidAddContentSecurityPolicies()
#8 0x7f6ae0542e89 blink::LocalFrameClientImpl::DidAddContentSecurityPolicies()
#9 0x7f6ae442ee7b blink::ContentSecurityPolicy::ReportAccumulatedHeaders()
#10 0x7f6ae4b9d1d2 blink::DocumentLoader::DidCommitNavigation()
#11 0x7f6ae4b9b923 blink::DocumentLoader::InstallNewDocument()
#12 0x7f6ae4b9b37f blink::DocumentLoader::EnsureWriter()
#13 0x7f6ae4b9999a blink::DocumentLoader::CommitData()
#14 0x7f6ae4b9bf12 blink::DocumentLoader::ProcessData()
#15 0x7f6ae4b9bdb4 blink::DocumentLoader::DataReceived()
#16 0x7f6ae285fa05 blink::RawResource::AppendData()
#17 0x7f6ae289ae1f blink::ResourceLoader::DidReceiveData()
#18 0x7f6aee384e5a content::WebURLLoaderImpl::Context::OnReceivedData()
#19 0x7f6aee385993 content::WebURLLoaderImpl::RequestPeerImpl::OnReceivedData()
#20 0x7f6aee370e77 content::URLResponseBodyConsumer::OnReadable()
#21 0x7f6aee36ca09 content::URLLoaderClientImpl::OnStartLoadingResponseBody()
#22 0x7f6aee585287 content::ThrottlingURLLoader::OnStartLoadingResponseBody()
#23 0x7f6aee67b25b content::mojom::URLLoaderClientStubDispatch::Accept()
#24 0x7f6aee588243 content::mojom::URLLoaderClientStub<>::Accept()
#25 0x7f6af2bbfd62 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#26 0x7f6af2bbf6b1 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept()
#27 0x7f6af2bbd515 mojo::FilterChain::Accept()
#28 0x7f6af2bc17f1 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#29 0x7f6af2bd6b34 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#30 0x7f6af2bd633c mojo::internal::MultiplexRouter::Accept()
#31 0x7f6af2bbd515 mojo::FilterChain::Accept()
#32 0x7f6af2bb1ac2 mojo::Connector::ReadSingleMessage()
#33 0x7f6af2bb2827 mojo::Connector::ReadAllAvailableMessages()
#34 0x7f6af2bb25ee mojo::Connector::OnHandleReadyInternal()
#35 0x7f6af2bb24cb mojo::Connector::OnWatcherHandleReady()

It will be fixed by:
https://codereview.chromium.org/2944373002/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5174a7f227b37a6f0bc93f56da97c49e22a88f7a

commit 5174a7f227b37a6f0bc93f56da97c49e22a88f7a
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Wed Jun 21 08:04:33 2017

CSP: Remove wrong DCHECK in CSPSourceList

Removing DCHECK :
```
  // When the '*' source is used, it must be the only one.
  DCHECK(!allow_star || (!allow_self && sources.empty()));
```
This is obviously wrong. That is the 'none' source that cannot be
present with other sources.

This was introduced by mistake in
https://crrev.com/2937503002/

BUG= 735049 

Review-Url: https://codereview.chromium.org/2944373002
Cr-Commit-Position: refs/heads/master@{#481138}

[modify] https://crrev.com/5174a7f227b37a6f0bc93f56da97c49e22a88f7a/content/common/content_security_policy/csp_source_list.cc
[modify] https://crrev.com/5174a7f227b37a6f0bc93f56da97c49e22a88f7a/content/common/content_security_policy/csp_source_list_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment