New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734991 link

Starred by 2 users
Status: Duplicate
Merged: issue 748152
Owner:
steve...@chromium.org
Closed: Jul 2017
Cc:
rogerta@chromium.org
ajha@chromium.org
█ kavvaru@chromium.org
msw@chromium.org
msarda@chromium.org
█ brajkumar@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Sign in overlay is not seen when opened settings as a window

Project Member Reported by sc00335...@techmahindra.com, Jun 20 2017 
Chrome Version: 59.0.3071.109
OS: Ubuntu 14.04,Windows

Pre-Condition: Enable "Show settings in a window" flag from chrome://flags

What steps will reproduce the problem?
(1) Launch chrome and open settings >> Now in opened window click on sign in to Chrome button and check for sign in overlay

Expected: Sign in overlay should get opened on clicking on it even when settings opened as window.
Actual: Instead nothing happens on clicking that button.

This is a regression issue broken in M47.

Good Build: 47.0.2510.0 dev
Bad Build: 47.0.2511.0 dev

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/9ee0841722352577f208463072d0c812d3b50765..ab7a90daddbe7d44558d8703b12204570ae98431

Suspecting https://codereview.chromium.org/1304943006 from changelog.

@shadi: Please confirm the behaviour and help in re-assigning if it is not related to your change.
Expected_sign in .png
124 KB View Download

Comment 1 by sc00335...@techmahindra.com, Jun 20 2017

Cc: msw@chromium.org rogerta@chromium.org
++ adding reviewers of above bug.

@msw/rogerta : Please confirm the behaviour

Comment 2 by ajha@chromium.org, Jun 20 2017

Cc: -msw@chromium.org
Owner: msw@chromium.org
Issue is reproducible on 61.0.3135.4 on Windows-10 but not seen on Mac OS 10.12.5.

Comment 3 by ew...@chromium.org, Jun 30 2017

Cc: msarda@chromium.org
Labels: -Pri-1 Pri-2
What is the "show settings in a window" flag? Is that ever planned to be launched? If not, we should close this bug out.

The sign-in screen that you took a screenshot of no longer exists in Chrome. We show the sign-in screen as a modal dialogue instead.

Demoting priority since it's Linux only.

Comment 4 by msw@chromium.org, Jul 12 2017

Cc: msw@chromium.org
Components: UI>Settings
Labels: -Pri-2 -M-60 Pri-3
Owner: steve...@chromium.org
Steven, can you comment on the "show settings in a window" flag? 
Your https://codereview.chromium.org/178863002 added that in 2014.

Perhaps we can remove the flag and choose a single desktop behavior?
Removing M-60 and using Pri-3 since this is old breakage behind a flag.

Comment 5 by steve...@chromium.org, Jul 12 2017

Labels: M-62
Yeah, we left the flag in IIRC because there was some discussion about whether it should be used in non-CrOS + Ash, which is no longer a thing.

We should remove the flag and make the behavior CrOS only.

Assigning a milestone because it should be quick to do and code cleanup is important, but leaving as a P3.

Comment 6 by steve...@chromium.org, Jul 24 2017

Mergedinto: 748152
Status: Duplicate (was: Assigned)
Deprecating settings-window on non CrOS platforms in  issue 748152
►

Sign in to add a comment