Issue metadata
Sign in to add a comment
|
Regression: Cursor overlaps with text in omnibox when window is dragged |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3071.109 OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1) Launch chrome and type some large text in omnibox >> Now restore windows and drag the window[Please refer video] (2)Observe cursor inside omnibox while dragging Expected: Cursor should stay at end of text only even on dragging Actual: Instead cursor gets moved with and overlaps with text while dragging. This is a regression issue broken in M58. Good Build: 58.0.3014.0 dev Bad Build: 58.0.3015.0 dev
,
Jun 21 2017
Bisect Information: -------------------- Using per revision bisect providing information below. You are probably looking for a change made after 451177 (known good), but no lat er than 451179 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/4d81d1e61673e8e3f988fe8efaebf630308f8e85..a33c8f5acb10c229da14134b9987e3b16eaa74f4 Review-Url: https://codereview.chromium.org/2660593002 yiyix@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Jun 28 2017
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daf838dca867613a3f7dc9fa915b14b6245da83e commit daf838dca867613a3f7dc9fa915b14b6245da83e Author: yiyix <yiyix@chromium.org> Date: Thu Jul 06 00:36:40 2017 Fix bug: Cursor overlaps with text in omnibox when window is dragged The cursor location used to get updated after the dragging event is over, so the cursor shows in the previous location for some time before jumping to the new location as shown in the bug. In this fix, Textfield::OnBoundsChanged will trigger location updating for text cursor as well. TEXT=TextfieldTest.TextfieldBoundsChangeTest Bug: 734988 Change-Id: Idbc05e59b8b97f76ec9d70b5c99b887e69798fda Reviewed-on: https://chromium-review.googlesource.com/559591 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#484422} [modify] https://crrev.com/daf838dca867613a3f7dc9fa915b14b6245da83e/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/daf838dca867613a3f7dc9fa915b14b6245da83e/ui/views/controls/textfield/textfield_unittest.cc
,
Jul 6 2017
,
Jul 7 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 7 2017
this bug caused another P1. It should land in M61 instead.
,
Jul 14 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Jun 20 2017