New issue
Advanced search Search tips

Issue 734973 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Firmware screens should use HTTPS URLs

Project Member Reported by mnissler@chromium.org, Jun 20 2017

Issue description

The firmware screens direct the user to http://google.com/chromeos/recovery for help. It's 2017, so this should be https://google.com/chromeos/recovery (note the 's').

I believe this code is in https://chromium.googlesource.com/chromiumos/platform/bmpblk/+/master/strings/

Will send a CL to adjust the URLs.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bmpblk/+/ed30b5473c7973e2e77d8fae59a495da31fbd243

commit ed30b5473c7973e2e77d8fae59a495da31fbd243
Author: Mattias Nissler <mnissler@chromium.org>
Date: Wed Jun 21 00:24:18 2017

Switch recovery URLs to https

BUG= chromium:734973 
TEST=Rebuild images and verify Url.png says https.

Change-Id: I7b71afd78b1f2465a806377769ff3cb864d26c3a
Reviewed-on: https://chromium-review.googlesource.com/541297
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@google.com>

[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ro/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/en/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/nl/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ca/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/hu/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ko/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/fr/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/nb/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/sr/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/zh-TW/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/fil/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/kn/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/Url.TXT
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/pl/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ms/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/cs/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ja/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/gu/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ta/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/fi/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/hr/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/pt-BR/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/te/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ar/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/sv/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/lv/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/mr/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/el/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/uk/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/lt/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ml/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/hi/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/pt-PT/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/vi/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/th/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/es-419/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/ru/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/tr/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/et/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/zh-CN/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/fa/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/de/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/bn/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/id/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/es/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/format.yaml
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/sl/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/da/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/it/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/bg/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/sk/firmware_strings.txt
[modify] https://crrev.com/ed30b5473c7973e2e77d8fae59a495da31fbd243/strings/locale/he/firmware_strings.txt

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment