New issue
Advanced search Search tips

Issue 734954 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests] 'Save password' bubble is seen even though Login button is not clicked at instagram.com

Project Member Reported by ranjitkan@chromium.org, Jun 20 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL:
===
https://chromium.googlesource.com/chromium/src/+/c5787e3c4df8dc3dbcd6f23b59b830ad63152899

Ref Bug:
========
https://bugs.chromium.org/p/chromium/issues/detail?id=728028

Thanks.!
 
Summary: [Missing Tests] 'Save password' bubble is seen even though Login button is not clicked at instagram.com (was: [Missing Tests]:Regression: 'Save password' bubble is seen even though Login button is not clicked at instagram.com)

Comment 2 by jochen@chromium.org, Jun 20 2017

Labels: -Pri-1 -ReleaseBlock-Stable -M-60 M-61 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbb84fd936d665eae716cfc8ea43308a73d2bf35

commit bbb84fd936d665eae716cfc8ea43308a73d2bf35
Author: Jochen Eisinger <jochen@chromium.org>
Date: Wed Jun 21 09:00:50 2017

Add regression test for password manager

We shouldn't treat multiple XHRs without changes to the password form as
a successful submission

BUG= 734954 ,  728028 
R=dvadym@chromium.org

Change-Id: I8394bb411f9db8236e452ddaa8e5488da3a7861e
Reviewed-on: https://chromium-review.googlesource.com/542775
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481153}
[modify] https://crrev.com/bbb84fd936d665eae716cfc8ea43308a73d2bf35/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Comment 4 by jochen@chromium.org, Jun 21 2017

Status: Fixed (was: Assigned)

Sign in to add a comment