New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734917 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jan 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
s...@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Regression: In chrome://sync-internals, focus gets lost after 'Search' tab when navigating using arrow keys.

Reported by ngu...@etouch.net, Jun 20 2017 
Chrome Version: 61.0.3136.0 (Official Build) fa10d4397863ac2df5724e53131b3e61a0d0ebb4-refs/heads/master@{#480665} (32/64-bit) 
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
1) Launch chrome, navigate to chrome://sync-internals and press Tab key.
2) Now navigate through different tabs using right arrow key.
3) Observe the focus after 'Search' tab.

Focus gets lost after 'Search' tab.

Focus should not get lost after 'Search' tab.

This is a Regression issue broken in M-60, will soon update other info
Manual bisect:
Good build: 60.0.3111.0 
Bad build: 60.0.3112.0
sync_actual.mp4
850 KB View Download
sync_expected.mp4
764 KB View Download

Comment 1 by rbasuvula@chromium.org, Jun 20 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: s...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3111.0 (Revision:474651).
Bad build:60.0.3112.0 (Revision:474897).

You are probably looking for a change made after 474813 (known good), but no later than 474814 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/e96185d01c286ffb9892e3f7dff6765bea1dc81b..6c146620037bf6c1222d5a0255be9a6ef2ce5137

From the CL above, assigning the issue to the concern owner

@skym: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2872023002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3136.0

Comment 2 by ngu...@etouch.net, Jun 20 2017 

Note: Above issue is reproducible on Chrome version: 61.0.3135.5.

Comment 3 by s...@chromium.org, Jun 20 2017

Components: -Internals Services>Sync
Labels: -Pri-1 OS-Android OS-Chrome Pri-3
Yeah, this is definitely caused by my changes. What's happening is that you're tabbing to a 7th tab that's hidden for now, unless the --enable-features=SyncUserEvents flag is specified.

However, given that sync-internals is a diagnosis only surface, and this bug isn't breaking anything, just kind of janky, I'm lowing priority. Will try to fix today if it turns out to be easy.

Comment 4 by s...@chromium.org, Jun 20 2017 

Looks like the problematic code is in https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/tabs.js?q=tabbox&sq=package:chromium&dr=CSs&l=151 , it isn't ignoring hidden elements.

Comment 5 by s...@chromium.org, Jun 20 2017

Status: Started (was: Assigned)
Fix posted https://codereview.chromium.org/2947013002/

Comment 6 by s...@chromium.org, Jan 17 2018

Cc: s...@chromium.org
Owner: ----
Status: Archived (was: Started)
Fixing this would have been nice, but impact is low. Closing as this likely isn't going to be done.
►

Sign in to add a comment