New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734897 link

Starred by 1 user
Status: Fixed
Owner:
benwells@chromium.org
Closed: Jun 2017
Cc:
█ mgiuca@chromium.org
dominickn@chromium.org
█ owe...@chromium.org
█ ortuno@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Update features / flags to support desktop PWAs

Project Member Reported by benwells@chromium.org, Jun 20 2017 
Feature BookmarkAppsMac will stay

switch / flag --enable-add-to-shelf will become a feature AppBanners. If turned on this will force BookmarkAppsMac to be true.

A new feature will also be added ExperimentalAppBanners which will be used to gate the new app banner UI (modal, not shown without developer calling an API). This will force AppBanners and BookmarkAppsMac to both be true.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab

commit c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab
Author: benwells <benwells@chromium.org>
Date: Wed Jun 28 05:10:32 2017

Replace --add-to-shelf flag with kAppBanners feature.

The add to shelf flag was poorly named and doesn't use the new feature
goodness.

With this change, functionality dependent on the kBookmarkApps flag is
also enabled if the kAppBanners flag is enabled.

BUG= 734897 

Review-Url: https://codereview.chromium.org/2944283002
Cr-Commit-Position: refs/heads/master@{#482889}

[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/browser/about_flags.cc
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/browser/banners/app_banner_manager_browsertest.cc
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/browser/banners/app_banner_manager_desktop.cc
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/browser/extensions/extension_util.cc
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/common/chrome_features.cc
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/common/chrome_features.h
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/common/chrome_switches.cc
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/chrome/common/chrome_switches.h
[modify] https://crrev.com/c421ccdbdd2c25b9d5d83eab1d8902aacb0d00ab/tools/metrics/histograms/enums.xml

Comment 3 by benwells@chromium.org, Jun 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment