"git cl upload" in third_party/chromite fails mysteriously |
||||
Issue description
What steps will reproduce the problem?
1. checkout the chrome tree
2. cd thid_party/chromite
3. git checkout -b some_branch
4. change some files
5. git cl upload
What is the expected result?
"git cl upload" just works
What happens instead of that?
"git cl upload" fails mysteriously:
Running presubmit upload checks ...
Traceback (most recent call last):
File "/usr/local/google/home/satorux/depot_tools/git_cl.py", line 6040, in <module>
sys.exit(main(sys.argv[1:]))
File "/usr/local/google/home/satorux/depot_tools/git_cl.py", line 6022, in main
return dispatcher.execute(OptionParser(), argv)
File "/usr/local/google/home/satorux/depot_tools/subcommand.py", line 252, in execute
return command(parser, args[1:])
File "/usr/local/google/home/satorux/depot_tools/git_cl.py", line 4890, in CMDupload
return cl.CMDUpload(options, args, orig_args)
File "/usr/local/google/home/satorux/depot_tools/git_cl.py", line 1634, in CMDUpload
change=change)
File "/usr/local/google/home/satorux/depot_tools/git_cl.py", line 1566, in RunHook
gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
File "/usr/local/google/home/satorux/depot_tools/presubmit_support.py", line 1348, in DoPresubmitChecks
results += executer.ExecPresubmitScript(presubmit_script, filename)
File "/usr/local/google/home/satorux/depot_tools/presubmit_support.py", line 1258, in ExecPresubmitScript
result = eval(function_name + '(*__args)', context)
File "<string>", line 1, in <module>
File "<string>", line 2489, in CheckChangeOnUpload
File "<string>", line 2285, in _CommonChecks
File "<string>", line 2456, in _CheckForWindowsLineEndings
IOError: [Errno 2] No such file or directory: 'lib/remote_access.py'
Please provide any additional information below. Attach a screenshot if
possible.
This seems to be failing when trying to run presubmit checks.
"git cl upload --bypass-hooks" works.
I wonder if there is a way to keep presubmit checks from running in third_party repositories.
+agable who might be familiar with presubmit checks per git log in depot_tools.
,
Jun 21 2017
agable: thank you for the info. I didn't know about the inherit-review-settings-ok. Let me remove this file.
,
Jun 21 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/357960ebb8e053359b83fc91e53aea4744d0d179 commit 357960ebb8e053359b83fc91e53aea4744d0d179 Author: Satoru Takabayashi <satorux@google.com> Date: Thu Jun 22 06:38:11 2017 Remove inherit-review-settings-ok Previously "git cl upload" from chrome's src/third_party/chromite failed because of this file (with this file, it inherits git cl settings from repos above). BUG= 734895 Change-Id: Idc8ff45c62e5f8e6e59640ca0fbbb3d07a649c15 Reviewed-on: https://chromium-review.googlesource.com/542635 Commit-Ready: Satoru Takabayashi <satorux@google.com> Tested-by: Satoru Takabayashi <satorux@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/5c6da25d104dab18ca9fbc0ae65309c6c3cffefe/inherit-review-settings-ok
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1ef8195341755378c1e1cbe05e5990b31dfac3b commit e1ef8195341755378c1e1cbe05e5990b31dfac3b Author: satorux <satorux@chromium.org> Date: Thu Jun 22 09:17:42 2017 Roll src/third_party/chromite/ df34c6894..357960ebb (35 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/df34c6894b82..357960ebb8e0 $ git log df34c6894..357960ebb --date=short --no-merges --format='%ad %ae %s' 2017-06-21 satorux Remove inherit-review-settings-ok 2017-06-21 hungte chromeos_config: Disable dev_installer_prebuilts and trybot_list for factory. 2017-06-21 ayatane sysmon: Remove cpu_time_percent() primer 2017-06-21 ayatane Add a venv python interpreter entry point 2017-06-21 ayatane sysmon: Move process metrics to its own module 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-19 nxia Move BuildFailureMessage to build_failure_message 2017-06-20 bhthompson Add bob and hana paladin builders 2017-06-15 bhthompson Add sentry and wizpig paladins 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-05-25 jrbarnette Adjust CQ coverage for ARC devices 2017-06-21 stevenjb Revert "crome_stages.py: Pass --internal to cros chrome-sdk" 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-20 hungte chromeos_config: generate factory configs for all release boards 2017-06-21 chrome-bot Update config settings by config-updater. 2017-06-20 chrome-bot Update config settings by config-updater. Created with: roll-dep src/third_party/chromite BUG= 734895 Review-Url: https://codereview.chromium.org/2946323004 Cr-Commit-Position: refs/heads/master@{#481489} [modify] https://crrev.com/e1ef8195341755378c1e1cbe05e5990b31dfac3b/DEPS
,
Jun 26 2017
Fixed! agable@, thank you for the suggestions! |
||||
►
Sign in to add a comment |
||||
Comment 1 by aga...@chromium.org
, Jun 20 2017Summary: "git cl upload" in third_party/chromite fails mysteriously (was: "git cl upload" in a git repository under third_party fails mysteriously)