servo micro and ina xml are not compatible |
|||
Issue descriptionI think the issue is that the xml is getting generated to interface 2, while servo micro i2c is on interface 4. Tom changed the i2c interface on cr50 to 2 to match, probably this needs to be done for servo micro too, to make config easier.. See: https://cs.corp.google.com/chromeos_public/src/third_party/hdctools/servo/servo_interfaces.py?l=122 https://cs.corp.google.com/chromeos_public/src/third_party/hdctools/servo/data/generate_ina_controls.py?q=generate_ina_controls.py&dr&l=129
,
Jul 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/11be0fb173b14e517e8578e3065c3b2076da5238 commit 11be0fb173b14e517e8578e3065c3b2076da5238 Author: Nicolas Boichat <drinkcat@google.com> Date: Sat Jul 08 04:30:07 2017 servo_micro: Switch stm32_i2c to index 2 This allows INA measurements to be taken. BUG= chromium:734894 TEST=sudo servod -b poppy -c poppy_r1_r2.xml dut-control -t 1 ppvar_dx_base_mw Change-Id: Ia047cf379832b3d534a52af70ca8e7f62921fa83 Reviewed-on: https://chromium-review.googlesource.com/557484 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Nick Sanders <nsanders@chromium.org> [modify] https://crrev.com/11be0fb173b14e517e8578e3065c3b2076da5238/servo/servo_interfaces.py [modify] https://crrev.com/11be0fb173b14e517e8578e3065c3b2076da5238/servo/data/servo_micro.xml
,
Jul 9
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
Should be fixed per #2. |
|||
►
Sign in to add a comment |
|||
Comment 1 by drinkcat@chromium.org
, Jun 30 2017Status: Available (was: Untriaged)