New issue
Advanced search Search tips

Issue 734874 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Disable ProgressIndicatorTestCase/testProgressIndicatorShownOnFormSubmit on iPhone Simulator.

Project Member Reported by gch...@chromium.org, Jun 20 2017

Issue description

Disable ProgressIndicatorTestCase/testProgressIndicatorShownOnFormSubmit on iPhone simulator due to the following error:

ProgressIndicatorTestCase/testProgressIndicatorShownOnFormSubmit: 
../../ios/chrome/test/earl_grey/chrome_earl_grey.mm:147: error: -[ProgressIndicatorTestCase testProgressIndicatorShownOnFormSubmit] : Exception: AssertionFailedException

Exception Name: AssertionFailedException
Exception Reason: ((([condition waitWithTimeout:testing::kWaitForPageLoadTimeout])) is true) failed
Exception Details: Page did not complete loading.

 

Comment 1 by gch...@chromium.org, Jun 20 2017

Labels: M-61

Comment 2 by gch...@chromium.org, Jun 20 2017

Correction: Disabled on all configurations. It looked like it was working on iPhone Simulator since EG tests were not running on those bots.

Comment 3 by gch...@chromium.org, Jun 20 2017

*It looked like it was working in iPhone Device ...

Comment 4 by gch...@chromium.org, Jun 20 2017

This CL is suspicious, as the failure started with the run that included it, and it touches related code: https://codereview.chromium.org/2908353003

It cannot be  reverted cleanly at this point.
Components: Test>iOS
Owner: baxley@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by baxley@chromium.org, Jun 26 2017

Cc: baxley@chromium.org
Components: -Test>iOS Tests>Disabled
Owner: eugene...@chromium.org
Assigning to Eugene for re-triage to someone on the web team (or anyone else appropriate).

If you have any questions, let me know.
Cc: -baxley@chromium.org michaeldo@chromium.org
Cc: -michaeldo@chromium.org
Labels: -Pri-2 Pri-1
Owner: michaeldo@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3517fe49c2b9103f54c9a3a0e603934c8dca609c

commit 3517fe49c2b9103f54c9a3a0e603934c8dca609c
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Wed Jul 05 21:07:52 2017

Re-enable testProgressIndicatorShownOnFormSubmit.

Bug:  734874 
Change-Id: Iad53b6b7221b03b7a761aca5774fbefcae4ec226
Reviewed-on: https://chromium-review.googlesource.com/559949
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484350}
[modify] https://crrev.com/3517fe49c2b9103f54c9a3a0e603934c8dca609c/ios/chrome/browser/web/progress_indicator_egtest.mm

Status: Fixed (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment