fast/backgrounds/size/contain-and-cover.html fails with libc++ |
||||||
Issue descriptionRepro steps: 1. Enable libc++ by applying this patch: https://codereview.chromium.org/2933573002 2. gn args out/Release: dcheck_always_on = true ffmpeg_branding = "Chrome" is_component_build = false is_debug = false proprietary_codecs = true strip_absolute_paths_from_debug_symbols = true symbol_level = 1 use_goma = true 3. ninja -C out/Release -j1024 webkit_layout_tests 4. third_party/WebKit/Tools/Scripts/run-webkit-tests fast/backgrounds/size/contain-and-cover.html There are some single pixel diffs in the test results. Over to eae@ for triage.
,
Jun 21 2017
Looks like a rounding change for alpha channels in image painting. I'd just rebaseline the test but over to paint just to make sure.
,
Jun 22 2017
It's totally fine to rebaseline this as part of the patch to change the library. Add the failure to TestExpectations to submit with your patch and then assign this bug to me. Any day now I'll be changing this test result as part of another patch, so I'll rebaseline as part of that change.
,
Jun 22 2017
I opened a CL recently that updates the test expectations (looks like it's going to land any second now): https://codereview.chromium.org/2948113004/
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8083ea0874d042cc7071d224b7a8718a69ed0af4 commit 8083ea0874d042cc7071d224b7a8718a69ed0af4 Author: thomasanderson <thomasanderson@chromium.org> Date: Thu Jun 22 20:07:50 2017 Update layout test expectations when using libc++ BUG=734873 TBR=eae@chromium.org Review-Url: https://codereview.chromium.org/2948113004 Cr-Commit-Position: refs/heads/master@{#481643} [modify] https://crrev.com/8083ea0874d042cc7071d224b7a8718a69ed0af4/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 27 2017
,
Jun 27 2017
,
Jun 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by thomasanderson@chromium.org
, Jun 20 2017