Issue metadata
Sign in to add a comment
|
unit_tests (DownloadProtectionServiceTest) is failing on 4 builders |
||||||||||||||||||||
Issue descriptionunit_tests failing on 4 builders Builders failed on: - Mac10.10 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests - Mac10.11 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests - Mac10.12 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests - Mac10.9 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests The two failing tests: DownloadProtectionServiceTest.CheckClientDownloadValidateRequestNoSignature DownloadProtectionServiceTest.CheckClientDownloadValidateRequest Link to build: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/19666 I think this is a regression from https://chromium.googlesource.com/chromium/src/+/6602ea616cce79869b300ffa82c3fc64fe422200
,
Jun 20 2017
,
Jun 20 2017
I'm going to roll this patch out.
,
Jun 20 2017
Unfortunately Rietveld cannot revert this and returns a 500 error: Revert failed: File too large. This sometimes happens when a file's contents are not uploaded because it is too large. Please revert manually. Sorry for the inconvenience. I've created a manual revert at https://chromium-review.googlesource.com/c/540918/
,
Jun 20 2017
revert CL landed. mortonm@, could you try repro locally? If it is flaky, use --gtest_repeat=10 or 20 on these failing tests and see if any of these repetition will fail. Otherwise, you might want to repro in an official build. https://www.chromium.org/developers/gn-build-configuration
,
Jun 20 2017
Issue 734918 has been merged into this issue.
,
Jun 27 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pdr@chromium.org
, Jun 20 2017