New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734857 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Flush command buffers automatically after timeout

Project Member Reported by sunn...@chromium.org, Jun 20 2017

Issue description

There are a few places where we flush the command buffer after deleting resources in a haphazard way:
1. Unintentionally, as a result of OrderingBarriers (without scheduler).
2. In LTHI::ReclaimResources when !visible.
3. In ResourcePool's eviction task if any resources were evicted. This task itself runs on a timeout.

ericrk@ said it would be nice if the command buffer had a flush after timeout functionality built-in. Worth doing?

 

Comment 1 by piman@chromium.org, Jun 27 2017

I'm not a fan of many time-based processes interacting in unknown ways... Also, GLES2Implmentation is used on threads that don't have a message loop so posting a task for the timeout is not generally possible.

Among others we have a facility to flush the command buffer after some time when inserting commands (see CommandBufferHelper::PeriodicFlushCheck), but it is not enabled for compositor/worker contexts because it was counter-productive at the time - we can certainly revisit if we see it helps.

Are there specific problems you want to addressed with a timeout-based flush? As opposed to the callers flushing when they need to?
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: sunn...@chromium.org
Status: Assigned (was: Untriaged)
sunnyps@, is this something still worth looking into?
Cc: jdarpinian@chromium.org
Status: WontFix (was: Assigned)
jdarpnian@ has been looking into command buffer performance recently for fixing specific webgl pages that are slow. Unless there's a specific case that would benefit, this is probably a WontFix.

Sign in to add a comment