New issue
Advanced search Search tips

Issue 734856 link

Starred by 1 user
Status: Fixed
Owner:
michaeldo@chromium.org
Closed: Jul 2017
Cc:
eugene...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

VisibleURLTestCase/testDoubleForwardNavigationToWebUIPage is disabled.

Project Member Reported by gch...@chromium.org, Jun 20 2017 
VisibleURLTestCase/testDoubleForwardNavigationToWebUIPage is disabled because it is failling  on all configurations except for iPhone device, with the following error:

VisibleURLTestCase/testDoubleForwardNavigationToWebUIPage: 
../../ios/chrome/test/earl_grey/chrome_earl_grey.mm:196: error: -[VisibleURLTestCase testDoubleForwardNavigationToWebUIPage] : Exception: AssertionFailedException

Exception Name: AssertionFailedException
Exception Reason: ((([condition waitWithTimeout:testing::kWaitForUIElementTimeout])) is true) failed
Exception Details: Failed waiting for web view containing 61.0.3136.0

Comment 1 by gch...@chromium.org, Jun 20 2017

Labels: M-61
It may have passed iPhone device because EG tests are not running on those bots.

Comment 2 by gch...@chromium.org, Jun 20 2017 

This CL is suspicious, as the failure started with the run that included it, and it touches related code: https://codereview.chromium.org/2908353003

It cannot be  reverted cleanly at this point.

Comment 3 by justincohen@chromium.org, Jun 21 2017

Components: Test>iOS
Owner: baxley@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by baxley@chromium.org, Jun 26 2017

Cc: baxley@chromium.org
Components: -Test>iOS Tests>Disabled
Owner: eugene...@chromium.org
Assigning to Eugene as the author of the test. Please re-assign as necessary. Maybe/hopefully it's a simple string change based on the CL gchatz@ mentioned.

Comment 5 by eugene...@chromium.org, Jun 26 2017

Cc: -baxley@chromium.org michaeldo@chromium.org
Per comment #2 seems like related to WebUI bug.

Comment 6 by eugene...@chromium.org, Jun 29 2017

Cc: -michaeldo@chromium.org eugene...@chromium.org
Labels: -Pri-2 Pri-1
Owner: ----

Comment 7 by cma...@chromium.org, Jul 14 2017 

Any update here Eugene?

Comment 8 by eugene...@chromium.org, Jul 14 2017

Owner: michaeldo@chromium.org
I think Mike fixed the breakage from cl/2908353003

Comment 9 by cma...@chromium.org, Jul 17 2017 

Please mark this bug as fixed if it is the case.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1751c38ce080866d4eb5fa81315d269bb810bdd8

commit 1751c38ce080866d4eb5fa81315d269bb810bdd8
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Mon Jul 17 18:52:41 2017

Enable testDoubleForwardNavigationToWebUIPage.

Bug:  734856 
Change-Id: I84190bfb4a41cb6a0b08f3c7964ba599040ea565
Reviewed-on: https://chromium-review.googlesource.com/572863
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487180}
[modify] https://crrev.com/1751c38ce080866d4eb5fa81315d269bb810bdd8/ios/chrome/browser/web/visible_url_egtest.mm

Comment 11 by michaeldo@chromium.org, Jul 17 2017

Status: Fixed (was: Assigned)

Comment 12 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment