[cast_channel] code clean up: create a parameter object for CastSocketService::OpenSocket() |
||||
Issue descriptionTo address code review comments: https://codereview.chromium.org/2925053005/diff/40001/components/cast_channel/cast_socket_service.h "With 7 parameters it makes an argument for introducing a Parameter Object (struct)." Also clean up parameters of CastSocketImpl's ctor if possible.
,
Jun 23 2017
,
Jul 18 2017
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1c22e2d5380b32a6379f43fff578fff2c807930 commit b1c22e2d5380b32a6379f43fff578fff2c807930 Author: Bin Zhao <zhaobin@chromium.org> Date: Fri Jul 21 02:10:38 2017 [cast_channel] clean up CastSocketImpl::OpenSocket() parameters Create a CastSocketConfig struct to hold cast socket related settings and clean up CastSocketImpl::OpenSocket() parameters Bug: 734855 Change-Id: I71a9847079a57f5f5c248c3b41354ac5f37bff66 Reviewed-on: https://chromium-review.googlesource.com/575793 Reviewed-by: Derek Cheng <imcheng@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488553} [modify] https://crrev.com/b1c22e2d5380b32a6379f43fff578fff2c807930/components/cast_channel/cast_socket.cc [modify] https://crrev.com/b1c22e2d5380b32a6379f43fff578fff2c807930/components/cast_channel/cast_socket.h [modify] https://crrev.com/b1c22e2d5380b32a6379f43fff578fff2c807930/components/cast_channel/cast_socket_service.cc [modify] https://crrev.com/b1c22e2d5380b32a6379f43fff578fff2c807930/components/cast_channel/cast_socket_service.h [modify] https://crrev.com/b1c22e2d5380b32a6379f43fff578fff2c807930/components/cast_channel/cast_socket_unittest.cc [modify] https://crrev.com/b1c22e2d5380b32a6379f43fff578fff2c807930/extensions/browser/api/cast_channel/cast_channel_api.cc
,
Jul 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sko...@chromium.org
, Jun 23 2017