New issue
Advanced search Search tips

Issue 734854 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 696822



Sign in to add a comment

SetCurrentChannel/SetCurrentFeatureSessionType not called in the utility process.

Project Member Reported by karandeepb@chromium.org, Jun 20 2017

Issue description

We don't call SetCurrentChannel/SetCurrentFeatureSessionType in the utility process. However these are used in the utility process. See extensions/utility/unpacker.cc, which calls Extension::Create, which would parse the manifest. This can lead to invalid checks. (For e.g., a feature which is available on trunk only, would be shown as not available in the utility process when on trunk, since the default channel is stable).


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/456585e962d667fdf18f17d69e3115dfac1d8e8b

commit 456585e962d667fdf18f17d69e3115dfac1d8e8b
Author: karandeepb <karandeepb@chromium.org>
Date: Thu Jun 29 03:41:55 2017

Extensions: Pass current channel and feature session type to extension unpack utility process.

The extension unpack utility process service uses Extension::Create which
involves availability checks for extension features. However we don't currently
set the current channel and feature session type in the utility process. This CL
fixes the issue by passing the current channel and feature session type to the
extension unpack utility process.

BUG= 734854 

Review-Url: https://codereview.chromium.org/2952353002
Cr-Commit-Position: refs/heads/master@{#483282}

[modify] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/browser/sandboxed_unpacker.cc
[modify] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/common/BUILD.gn
[rename] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/common/common_param_traits.h
[modify] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/common/extension_message_generator.h
[modify] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/common/extension_messages.cc
[modify] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/common/extension_messages.h
[modify] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/common/extension_unpacker.mojom
[add] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/common/extension_unpacker.typemap
[delete] https://crrev.com/14d5ed2dd6b7ca8b6eea5875c9c64e142846e4b6/extensions/common/manifest_location.typemap
[modify] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/common/typemaps.gni
[modify] https://crrev.com/456585e962d667fdf18f17d69e3115dfac1d8e8b/extensions/utility/utility_handler.cc

Status: Fixed (was: Assigned)

Sign in to add a comment