New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

Add tests for symbolize_trace.

Project Member Reported by erikc...@chromium.org, Jun 20 2017

Issue description

There are no tests. This makes it very easy to break.
 

Comment 1 by dskiba@chromium.org, Jun 20 2017

There is 1 unittest in symbolize_trace_unittest.py. The only problem is that it doesn't run on presubmit, I'm talking to catapult guys about it.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d2888215cb41f51f44a904bfa90faab9b720799

commit 9d2888215cb41f51f44a904bfa90faab9b720799
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jun 21 01:32:36 2017

Roll src/third_party/catapult/ 1556ddcf2..a64c010c7 (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1556ddcf20a1..a64c010c74cc

$ git log 1556ddcf2..a64c010c7 --date=short --no-merges --format='%ad %ae %s'
2017-06-20 benjhayden Categorize diagnostics in how-to-write-metrics.md.
2017-06-20 erikchen Move symbolize_trace from tracing/bin to tracing/tracing/extras/symbolizer.

Created with:
  roll-dep src/third_party/catapult
BUG= 734852 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iaffc9cdd2e7aa37a482dce08c4bde5dd233dfad1
Reviewed-on: https://chromium-review.googlesource.com/541922
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481065}
[modify] https://crrev.com/9d2888215cb41f51f44a904bfa90faab9b720799/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1311268993d21e1b65fa406d2b3783df34a12394

commit 1311268993d21e1b65fa406d2b3783df34a12394
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Jun 22 18:19:13 2017

Roll src/third_party/catapult/ 76def8902..a857866b2 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/76def89024c6..a857866b281f

$ git log 76def8902..a857866b2 --date=short --no-merges --format='%ad %ae %s'
2017-06-22 erikchen Make tracing/extras and tracing/extras/symbolizer into modules.

Created with:
  roll-dep src/third_party/catapult
BUG= 734852 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia275b1a5dc830f7a6a05dfab2743ead4d9af5ff9
Reviewed-on: https://chromium-review.googlesource.com/545079
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481607}
[modify] https://crrev.com/1311268993d21e1b65fa406d2b3783df34a12394/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ab83c1d7a8ff995596073b1381cc6222c1d8d6

commit c1ab83c1d7a8ff995596073b1381cc6222c1d8d6
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Sat Jun 24 02:21:20 2017

Roll src/third_party/catapult/ 677b02eac..28f796f29 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/677b02eacd6f..28f796f29c9e

$ git log 677b02eac..28f796f29 --date=short --no-merges --format='%ad %ae %s'
2017-06-23 erikchen Add an end-to-end test for symbolize_trace on macOS.

Created with:
  roll-dep src/third_party/catapult
BUG=729103, 734852 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I9173177dbc84fd3603ee29be5fd7c4d3eb25e25f
Reviewed-on: https://chromium-review.googlesource.com/546849
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482123}
[modify] https://crrev.com/c1ab83c1d7a8ff995596073b1381cc6222c1d8d6/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment