New issue
Advanced search Search tips

Issue 734849 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 735327



Sign in to add a comment

We should make Position constructor and family to take const Node&

Project Member Reported by yosin@chromium.org, Jun 20 2017 
Following Position constructor and family should take const Node&, since node parameter can not
be null.

Note: We should take care call sites of Position(Node*, int offset) where we sometimes pass
null node.

- Position(Node*, PositionAnchorType)
- Position(Node*, int offset)
- EditingPositionOf(Node*, int offset)
- BeforeNode(Node*)
- AfterNode(Node*)
- FirstPositionInNode(Node*)
- LastPositionInNode(Node*)
- FirstPositionInOrBeforeNode(Node*)
- LastPositionInOrBeforeNode(Node*)

We should change VisiblePositon version of them too:

AfterNode(Node*);
BeforeNode(Node*);
- FirstPositionInNode(Node*);
- InParentAfterNode(const Node&);
- InParentBeforeNode(const Node&);
- LastPositionInNode(Node*);
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/638c26b1f1ba5238cbf4d72075477ab38b15376f

commit 638c26b1f1ba5238cbf4d72075477ab38b15376f
Author: yosin <yosin@chromium.org>
Date: Wed Jun 21 06:45:20 2017

Introduce Position constructor taking const Node&

This patch introduces |Position| constructor taking |const Node&| to avoid
to use |const_cast<Node*>()| for improving code health.

This patch also changes |Position| constructor taking |Node*| to |const Node*|
to avoid |const_cast| in |const Node&| |Position| constructor.

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2949763002
Cr-Commit-Position: refs/heads/master@{#481128}

[modify] https://crrev.com/638c26b1f1ba5238cbf4d72075477ab38b15376f/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
[modify] https://crrev.com/638c26b1f1ba5238cbf4d72075477ab38b15376f/third_party/WebKit/Source/core/editing/Position.cpp
[modify] https://crrev.com/638c26b1f1ba5238cbf4d72075477ab38b15376f/third_party/WebKit/Source/core/editing/Position.h
[modify] https://crrev.com/638c26b1f1ba5238cbf4d72075477ab38b15376f/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
[modify] https://crrev.com/638c26b1f1ba5238cbf4d72075477ab38b15376f/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp

Comment 2 by yosin@chromium.org, Jun 21 2017

Blocking: 735327

Comment 3 by yosin@chromium.org, Jun 21 2017

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb

commit f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb
Author: yosin <yosin@chromium.org>
Date: Wed Jun 21 22:53:29 2017

Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

This patch is a preparation of make |Position| to hold |const Node&|[1]

[1] http://crbug.com/735327 Position should hold const Node instead of Node

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2950053002
Cr-Commit-Position: refs/heads/master@{#481342}

[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/Position.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/Position.h
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/PositionIterator.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/PositionTest.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb/third_party/WebKit/Source/core/html/TextControlElement.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eeccaf7268c04ca0f50c076c9ac827167b6735a

commit 1eeccaf7268c04ca0f50c076c9ac827167b6735a
Author: yosin <yosin@chromium.org>
Date: Thu Jun 22 05:34:21 2017

Make Position::AfterNode() to take const Node& instead of Node*

This patch makes |Position::AfterNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.

[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2953683004
Cr-Commit-Position: refs/heads/master@{#481450}

[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/dom/RangeTest.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/Position.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/Position.h
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/PositionTest.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/1eeccaf7268c04ca0f50c076c9ac827167b6735a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6987d19cbf857ea5158f967d304b0572048c7199

commit 6987d19cbf857ea5158f967d304b0572048c7199
Author: yosin <yosin@chromium.org>
Date: Fri Jun 23 05:34:06 2017

Make Position::FirstPositionInNode() to take const Node& instead of Node*

This patch makes |Position::FirstPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.

This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.

[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952983002
Cr-Commit-Position: refs/heads/master@{#481810}

[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/EphemeralRange.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/Position.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/Position.h
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/PositionTest.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/SurroundingText.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/TextFinder.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp
[modify] https://crrev.com/6987d19cbf857ea5158f967d304b0572048c7199/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377

commit 5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377
Author: yosin <yosin@chromium.org>
Date: Tue Jun 27 01:29:55 2017

Make Position::LastPositionInNode() to take const Node& instead of Node*

This patch makes |Position::LastPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.

This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.

[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2962473002
Cr-Commit-Position: refs/heads/master@{#482496}

[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/EphemeralRange.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/Position.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/Position.h
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/PositionTest.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/SurroundingText.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/TextFinder.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 27 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by yosin@chromium.org, Jul 9

Status: Available (was: Untriaged)
►

Sign in to add a comment