Make WebView and WebViewStub use brotli credits |
|
Issue descriptionRelated to bug 688077 , it would be really nice if we could have a single way to produce about:credits across all apks. One goal is to delete "webview_licenses.py" in favour of Chrome's licenses.py (now used in Monochrome as well). The two scripts produce the same license information, but in different HTML using completely different .py files. The secondary goal is to shrink about:credits for webview and the stub apk. For SystemWebView.apk, I *think* it might be as easy as creating another LicenseContentProvider that calls AwBrowserProcess.loadLibrary() rather than ChromeBrowserInitializer. For the stub apk, something along the lines of: * Use the donorPackage metadata + some PackageManager API to get at the system image Monochrome.apk (and include disabled packages): * Managed/supervised users can have preinstalled apps "uninstalled". They're still physically there on disk of course but the package manager has been told to pretend they aren't installed by the device management app. * Once we have Monochrome's classloader, use that to load the native library & retrieve the credits asset.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21707ea80356d008afaba63d6f288b43378b90cd commit 21707ea80356d008afaba63d6f288b43378b90cd Author: Yipeng Wang <yipengw@chromium.org> Date: Fri Jul 14 17:01:46 2017 [about:credits] Make webview use chrome license file This CL also deletes webview_licenses.py and related files. Bug: 734846 Change-Id: Ib1dcdbd10c8c97993811e0c977bfaa68d0562315 Reviewed-on: https://chromium-review.googlesource.com/569075 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yipeng Wang <yipengw@chromium.org> Cr-Commit-Position: refs/heads/master@{#486783} [modify] https://crrev.com/21707ea80356d008afaba63d6f288b43378b90cd/android_webview/BUILD.gn [modify] https://crrev.com/21707ea80356d008afaba63d6f288b43378b90cd/android_webview/tools/PRESUBMIT.py [delete] https://crrev.com/82b35f8e43fb59475ac2d3d2fc76cf8eb7548f5f/android_webview/tools/webview_licenses.py [modify] https://crrev.com/21707ea80356d008afaba63d6f288b43378b90cd/docs/adding_to_third_party.md [delete] https://crrev.com/82b35f8e43fb59475ac2d3d2fc76cf8eb7548f5f/testing/scripts/webview_licenses.py [modify] https://crrev.com/21707ea80356d008afaba63d6f288b43378b90cd/tools/OWNERS [delete] https://crrev.com/82b35f8e43fb59475ac2d3d2fc76cf8eb7548f5f/tools/copyright_scanner/PRESUBMIT.py [delete] https://crrev.com/82b35f8e43fb59475ac2d3d2fc76cf8eb7548f5f/tools/copyright_scanner/__init__.py [delete] https://crrev.com/82b35f8e43fb59475ac2d3d2fc76cf8eb7548f5f/tools/copyright_scanner/copyright_scanner.py [delete] https://crrev.com/82b35f8e43fb59475ac2d3d2fc76cf8eb7548f5f/tools/copyright_scanner/copyright_scanner_unittest.py [delete] https://crrev.com/82b35f8e43fb59475ac2d3d2fc76cf8eb7548f5f/tools/copyright_scanner/third_party_files_whitelist.txt [modify] https://crrev.com/21707ea80356d008afaba63d6f288b43378b90cd/tools/tests/OWNERS |
|
►
Sign in to add a comment |
|
Comment 1 by agrieve@chromium.org
, Jun 20 2017