New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734841 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature
M61



Sign in to add a comment

Extend SearchResultTileItemView to show Play Store rating and price

Project Member Reported by weidongg@chromium.org, Jun 20 2017

Issue description

This is an copy of bug created on chromium bugtracker for b/62584065

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63ddedc4cd3f0a35990b14b618b5415d1a9baeba

commit 63ddedc4cd3f0a35990b14b618b5415d1a9baeba
Author: weidongg <weidongg@chromium.org>
Date: Thu Jun 22 19:12:44 2017

Show Play Store rating and price in app list

1. Provide interfaces in app_list::SearchResult to set price and rating
for instant and play store apps based on specs.
2. Change the layouts of SearchResultTileItemListView and
SearchResultTileItemView to show price and rating properly based on
specs.

Specifications:
https://screenshot.googleplex.com/AFQ5HnrMYch
https://screenshot.googleplex.com/0opcNunaJrZ

The screenshot: https://screenshot.googleplex.com/Kv0xzOVZLqs

BUG= 734841 

Review-Url: https://codereview.chromium.org/2949733002
Cr-Commit-Position: refs/heads/master@{#481618}

[modify] https://crrev.com/63ddedc4cd3f0a35990b14b618b5415d1a9baeba/ui/app_list/search_result.cc
[modify] https://crrev.com/63ddedc4cd3f0a35990b14b618b5415d1a9baeba/ui/app_list/search_result.h
[modify] https://crrev.com/63ddedc4cd3f0a35990b14b618b5415d1a9baeba/ui/app_list/search_result_observer.h
[modify] https://crrev.com/63ddedc4cd3f0a35990b14b618b5415d1a9baeba/ui/app_list/views/search_result_tile_item_list_view.cc
[modify] https://crrev.com/63ddedc4cd3f0a35990b14b618b5415d1a9baeba/ui/app_list/views/search_result_tile_item_list_view.h
[modify] https://crrev.com/63ddedc4cd3f0a35990b14b618b5415d1a9baeba/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/63ddedc4cd3f0a35990b14b618b5415d1a9baeba/ui/app_list/views/search_result_tile_item_view.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c5ff0c68a0169cfd8c044703225453fa1213fa9

commit 8c5ff0c68a0169cfd8c044703225453fa1213fa9
Author: scottmg <scottmg@chromium.org>
Date: Thu Jun 22 19:31:25 2017

Revert of Show Play Store rating and price in app list (patchset #5 id:80001 of https://codereview.chromium.org/2949733002/ )

Reason for revert:
dbg cros failed to compile, unfortunately i guess that's not on the cq :/

log here:
https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Builder%20%28dbg%29/88671

Original issue's description:
> Show Play Store rating and price in app list
>
> 1. Provide interfaces in app_list::SearchResult to set price and rating
> for instant and play store apps based on specs.
> 2. Change the layouts of SearchResultTileItemListView and
> SearchResultTileItemView to show price and rating properly based on
> specs.
>
> Specifications:
> https://screenshot.googleplex.com/AFQ5HnrMYch
> https://screenshot.googleplex.com/0opcNunaJrZ
>
> The screenshot: https://screenshot.googleplex.com/Kv0xzOVZLqs
>
> BUG= 734841 
>
> Review-Url: https://codereview.chromium.org/2949733002
> Cr-Commit-Position: refs/heads/master@{#481618}
> Committed: https://chromium.googlesource.com/chromium/src/+/63ddedc4cd3f0a35990b14b618b5415d1a9baeba

TBR=hejq@chromium.org,xiyuan@chromium.org,warx@chromium.org,weidongg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 734841 

Review-Url: https://codereview.chromium.org/2947313003
Cr-Commit-Position: refs/heads/master@{#481626}

[modify] https://crrev.com/8c5ff0c68a0169cfd8c044703225453fa1213fa9/ui/app_list/search_result.cc
[modify] https://crrev.com/8c5ff0c68a0169cfd8c044703225453fa1213fa9/ui/app_list/search_result.h
[modify] https://crrev.com/8c5ff0c68a0169cfd8c044703225453fa1213fa9/ui/app_list/search_result_observer.h
[modify] https://crrev.com/8c5ff0c68a0169cfd8c044703225453fa1213fa9/ui/app_list/views/search_result_tile_item_list_view.cc
[modify] https://crrev.com/8c5ff0c68a0169cfd8c044703225453fa1213fa9/ui/app_list/views/search_result_tile_item_list_view.h
[modify] https://crrev.com/8c5ff0c68a0169cfd8c044703225453fa1213fa9/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/8c5ff0c68a0169cfd8c044703225453fa1213fa9/ui/app_list/views/search_result_tile_item_view.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c99c46b5cb4ad91fc69229127369bf6d0403ae

commit d8c99c46b5cb4ad91fc69229127369bf6d0403ae
Author: weidongg <weidongg@chromium.org>
Date: Thu Jun 22 21:05:22 2017

Reland: Show Play Store rating and price in app list

1. Provide interfaces in app_list::SearchResult to set price and rating
for instant and play store apps based on specs.
2. Change the layouts of SearchResultTileItemListView and
SearchResultTileItemView to show price and rating properly based on
specs.

Specifications:
https://screenshot.googleplex.com/AFQ5HnrMYch
https://screenshot.googleplex.com/0opcNunaJrZ

The screenshot: https://screenshot.googleplex.com/Kv0xzOVZLqs

BUG= 734841 

Review-Url: https://codereview.chromium.org/2949733002
Cr-Commit-Position: refs/heads/master@{#481660}

[modify] https://crrev.com/d8c99c46b5cb4ad91fc69229127369bf6d0403ae/ui/app_list/search_result.cc
[modify] https://crrev.com/d8c99c46b5cb4ad91fc69229127369bf6d0403ae/ui/app_list/search_result.h
[modify] https://crrev.com/d8c99c46b5cb4ad91fc69229127369bf6d0403ae/ui/app_list/search_result_observer.h
[modify] https://crrev.com/d8c99c46b5cb4ad91fc69229127369bf6d0403ae/ui/app_list/views/search_result_tile_item_list_view.cc
[modify] https://crrev.com/d8c99c46b5cb4ad91fc69229127369bf6d0403ae/ui/app_list/views/search_result_tile_item_list_view.h
[modify] https://crrev.com/d8c99c46b5cb4ad91fc69229127369bf6d0403ae/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/d8c99c46b5cb4ad91fc69229127369bf6d0403ae/ui/app_list/views/search_result_tile_item_view.h

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment