New issue
Advanced search Search tips

Issue 734831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Update Strings on "Reload Page for Updated Permissions" infobar

Project Member Reported by emilyschechter@chromium.org, Jun 20 2017

Issue description

We would like to update the desktop infobar with the following string:

To apply your updated settings to this site, reload this page
RELOAD 

(I'm not sure what team should own this so adding it to the general permissions component)
 
Owner: patricia...@chromium.org
Status: Assigned (was: Untriaged)
Patti - could you look into this?
Status: Started (was: Assigned)
In progress at https://codereview.chromium.org/2952543002/.

See https://drive.google.com/open?id=0BzEa5HU1aAqBamtNSUlFNTBZM3M for before/after screenshots (Mac). Attached also is a screenshot of what it looks like in Views (taken on Linux, but will look the same on Windows, just probably with a different font).
Screen Shot 2017-06-20 at 6.20.42 pm.png
19.9 KB View Download
linux-pageinfo-infobar.png
20.7 KB View Download
Components: UI>Browser>Bubbles>PageInfo
The infobar delegate is in the Page Info code, so I'm adding that component, too.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17d7d8d729af2b0f3a73b27a9e2fe9a537a8dfd6

commit 17d7d8d729af2b0f3a73b27a9e2fe9a537a8dfd6
Author: patricialor <patricialor@chromium.org>
Date: Wed Jun 21 00:57:36 2017

Permissions: Update icon and string for the site permission settings infobar.

Update the icon and the string used for the infobar that shows up when changing
the site settings via the Page Info bubble.

See https://drive.google.com/open?id=0BzEa5HU1aAqBamtNSUlFNTBZM3M for
before/after screenshots of the infobar.

BUG= 734831 
TEST=Navigate to https://www.google.com/. Open the Page Info bubble by clicking
the "Secure" lock, and change "Location" to "Block". Close the Page Info bubble
and observe the infobar's new string and icon.

Review-Url: https://codereview.chromium.org/2952543002
Cr-Commit-Position: refs/heads/master@{#481051}

[modify] https://crrev.com/17d7d8d729af2b0f3a73b27a9e2fe9a537a8dfd6/chrome/browser/ui/page_info/page_info_infobar_delegate.cc
[modify] https://crrev.com/17d7d8d729af2b0f3a73b27a9e2fe9a537a8dfd6/components/page_info_strings.grdp

Labels: M-61
Status: Fixed (was: Started)

Sign in to add a comment