Site Isolation Linux FYI bot failing ContentSubresourceFilterThrottleManagerTest.LogActivation |
||
Issue descriptionAs of https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/17865, the Site Isolation Linux FYI bot is failing component_unittests: ContentSubresourceFilterThrottleManagerTest.LogActivation [ RUN ] ContentSubresourceFilterThrottleManagerTest.LogActivation Xlib: extension "RANDR" missing on display ":99". ../../components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc:165: Failure Expected: expect_activation Which is: true To be equal to: !!message Which is: false [ FAILED ] ContentSubresourceFilterThrottleManagerTest.LogActivation (120 ms) This looks like it's probably due to csharrison's https://chromium-review.googlesource.com/527457. He said he'd take a look. (Please disable or revert if it looks like it can't be fixed in the next day, so that we can spot other regressions on the bot. Thanks!)
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/302578aad91fb4ee0632618171f76ca8c71c79b4 commit 302578aad91fb4ee0632618171f76ca8c71c79b4 Author: Charles Harrison <csharrison@chromium.org> Date: Wed Jun 21 23:26:21 2017 Fix ContentSubresourceFilterThrottleManagerTest.LogActivation We were expecting an activation IPC from a subframe without activation. This only worked because we were listening for the message from the render process sink associated with the frame, so we just snooped on a previous message from another frame hosted within the same process. Bug: 734823 Change-Id: I45a07bab3316a8ca4736db80e2897afee9a3eed6 Reviewed-on: https://chromium-review.googlesource.com/540623 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#481353} [modify] https://crrev.com/302578aad91fb4ee0632618171f76ca8c71c79b4/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
,
Jun 22 2017
The bot is green now-- thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by csharrison@chromium.org
, Jun 20 2017