New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734814 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 725977



Sign in to add a comment

Tablet WM: Swiping up on system tray to show the system tray bubble

Project Member Reported by minch@chromium.org, Jun 19 2017

Issue description

Swiping up on the system tray to show the system tray bubble.

1. This is only for horizontal shelf. Since tablet will has only horizontal shelf in the future.

2.Update the position of the bubble according to the position of the gesture.

3.For SCROLL_END event. To show or hide the bubble depends on the position of the gesture. Bubble is split into two parts.
End in the lower part (one-third position) will hide the bubble;
Otherwise, should always show the bubble.

4.For FLING event. To show or hide the bubble depends on gesture position and velocity.
If the fling velocity larger than 100dips/sec, show or hide according to the fling direction;
Otherwise, show or hide depends on the position.
 

Comment 1 by minch@chromium.org, Jun 19 2017

Description: Show this description

Comment 2 by minch@chromium.org, Jun 19 2017

Description: Show this description

Comment 3 by minch@chromium.org, Jun 22 2017

Cc: tdander...@chromium.org omrilio@chromium.org zork@chromium.org x...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6131f3b26bf5d8904d266f9f826fb811b28f875

commit e6131f3b26bf5d8904d266f9f826fb811b28f875
Author: minch <minch@chromium.org>
Date: Tue Jun 27 18:48:45 2017

Tablet WM : Swiping on system tray bubble.

Swiping up on the system tray to open the system tray bubble.
1.This works only for tablet and horizontal shelf.

2.Update the bounds of the bubble according to the position of the gesture.

3.For SCROLL_END event. To show or hide the bubble depends on
the position of the gesture. Bubble is split into two parts.
End in the lower part (one-third position) will hide the bubble;
Otherwise, should always show the bubble.

4.For FLING event. To show or hide the bubble depends on
gesture position and velocity.
If the fling velocity larger than |kSwipingVelocity|, show or hide
according to the fling direction;
Otherwise, show or hide depends on the position.

BUG= 734814 

Review-Url: https://codereview.chromium.org/2930123002
Cr-Commit-Position: refs/heads/master@{#482696}

[modify] https://crrev.com/e6131f3b26bf5d8904d266f9f826fb811b28f875/ash/system/tray/system_tray.cc
[modify] https://crrev.com/e6131f3b26bf5d8904d266f9f826fb811b28f875/ash/system/tray/system_tray.h
[modify] https://crrev.com/e6131f3b26bf5d8904d266f9f826fb811b28f875/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/e6131f3b26bf5d8904d266f9f826fb811b28f875/ash/system/tray/system_tray_bubble.h
[modify] https://crrev.com/e6131f3b26bf5d8904d266f9f826fb811b28f875/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/e6131f3b26bf5d8904d266f9f826fb811b28f875/ash/system/tray/tray_event_filter.cc

Comment 5 by minch@chromium.org, Jul 18 2017

Status: Fixed (was: Started)

Comment 6 by minch@chromium.org, Sep 5 2017

Labels: M-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment