Fix ash_unittests that use DeviceDataManager for --mus |
||||||
Issue descriptionThey use DeviceDataManager, which isn't created in --mus. Specifically: -TrayIMETest.HidesOnA11yEnabled -TrayIMETest.PerformActionOnDetailedView -VirtualKeyboardControllerAlwaysEnabledTest.DoesNotSuppressKeyboard -VirtualKeyboardControllerAutoTest.DisabledIfInternalKeyboardPresent -VirtualKeyboardControllerAutoTest.DisabledIfNoTouchScreen -VirtualKeyboardControllerAutoTest.EnabledDuringMaximizeMode -VirtualKeyboardControllerAutoTest.HandleMultipleKeyboardsPresent -VirtualKeyboardControllerAutoTest.SuppressedIfExternalKeyboardPresent -VirtualKeyboardControllerAutoTest.SuppressedInMaximizedMode -VirtualKeyboardControllerTest.RestoreKeyboardDevices
,
Jun 28 2017
Perhaps obvious note: They fail in --mash too.
,
Oct 12 2017
Apparently there are some stylus tests that fail on this as well. They use ui::test::DeviceDataManagerTestAPI to fake a stylus eject event. -PaletteTrayTestWithInternalStylus.WelcomeBubbleShownOnEject -PaletteTrayTestWithInternalStylus.WelcomeBubbleNotShownIfShownBefore -PaletteTrayTestWithInternalStylus.WelcomeBubbleNotShownIfAutoOpenPaletteTrue
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f336c50912b9f4e2e3e8ed401e87461715ab872 commit 6f336c50912b9f4e2e3e8ed401e87461715ab872 Author: James Cook <jamescook@chromium.org> Date: Wed Oct 25 15:08:19 2017 cros: Fix ui::InputDeviceManager usage for mash The ash process now has an InputDeviceManager, so we don't need to check for null or skip tests that use it. Convert PaletteTrayTests to avoid usage of DeviceDataManagerTestAPI, since DeviceDataManager doesn't exist on mash. Bug: 682460 , 734812 Test: ash_unittests Change-Id: If0d75de124af664f530f6cce5af6f95588c8265c Reviewed-on: https://chromium-review.googlesource.com/735130 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#511462} [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/palette/palette_tray_test_api.h [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/palette/palette_tray_unittest.cc [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/power/power_button_display_controller.cc [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/testing/buildbot/filters/ash_unittests_mash.filter [modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/testing/buildbot/filters/ash_unittests_mus.filter
,
Oct 25 2017
I'm near this code, so I'll take a look.
,
Oct 27 2017
The pure DeviceDataManager ones are fixed. There are still a few disabled because touchscreen calibration doesn't work. I filed issue 779118 for those.
,
Jan 22 2018
,
Jan 23 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamescook@chromium.org
, Jun 28 2017