New issue
Advanced search Search tips

Issue 734812 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 731255



Sign in to add a comment

Fix ash_unittests that use DeviceDataManager for --mus

Project Member Reported by sky@chromium.org, Jun 19 2017

Issue description

They use DeviceDataManager, which isn't created in --mus. Specifically:

-TrayIMETest.HidesOnA11yEnabled
-TrayIMETest.PerformActionOnDetailedView
-VirtualKeyboardControllerAlwaysEnabledTest.DoesNotSuppressKeyboard
-VirtualKeyboardControllerAutoTest.DisabledIfInternalKeyboardPresent
-VirtualKeyboardControllerAutoTest.DisabledIfNoTouchScreen
-VirtualKeyboardControllerAutoTest.EnabledDuringMaximizeMode
-VirtualKeyboardControllerAutoTest.HandleMultipleKeyboardsPresent
-VirtualKeyboardControllerAutoTest.SuppressedIfExternalKeyboardPresent
-VirtualKeyboardControllerAutoTest.SuppressedInMaximizedMode
-VirtualKeyboardControllerTest.RestoreKeyboardDevices

 
Cc: sadrul@chromium.org riajiang@chromium.org
 Issue 695561  has been merged into this issue.
Perhaps obvious note: They fail in --mash too.

Cc: sammiequon@chromium.org
Apparently there are some stylus tests that fail on this as well. They use ui::test::DeviceDataManagerTestAPI to fake a stylus eject event.

-PaletteTrayTestWithInternalStylus.WelcomeBubbleShownOnEject
-PaletteTrayTestWithInternalStylus.WelcomeBubbleNotShownIfShownBefore
-PaletteTrayTestWithInternalStylus.WelcomeBubbleNotShownIfAutoOpenPaletteTrue

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f336c50912b9f4e2e3e8ed401e87461715ab872

commit 6f336c50912b9f4e2e3e8ed401e87461715ab872
Author: James Cook <jamescook@chromium.org>
Date: Wed Oct 25 15:08:19 2017

cros: Fix ui::InputDeviceManager usage for mash

The ash process now has an InputDeviceManager, so we don't need to
check for null or skip tests that use it.

Convert PaletteTrayTests to avoid usage of DeviceDataManagerTestAPI,
since DeviceDataManager doesn't exist on mash.

Bug:  682460 ,  734812 
Test: ash_unittests
Change-Id: If0d75de124af664f530f6cce5af6f95588c8265c
Reviewed-on: https://chromium-review.googlesource.com/735130
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511462}
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/palette/palette_tray_test_api.h
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/palette/palette_tray_unittest.cc
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/power/power_button_display_controller.cc
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/ash/system/status_area_widget_unittest.cc
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/6f336c50912b9f4e2e3e8ed401e87461715ab872/testing/buildbot/filters/ash_unittests_mus.filter

Owner: jamescook@chromium.org
Status: Started (was: Assigned)
I'm near this code, so I'll take a look.

Status: Fixed (was: Started)
The pure DeviceDataManager ones are fixed. There are still a few disabled because touchscreen calibration doesn't work. I filed  issue 779118  for those.

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment