New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734809 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 731255



Sign in to add a comment

Fix ash_unittests that uses AshNativeCursorManager

Project Member Reported by sky@chromium.org, Jun 19 2017

Issue description

There are a number of ash_unittests that currently fail in --mus because we are not creating AshNativeCursorManager. Specifically this is the set of failing tests:
-MagnificationControllerTest.PanWindowToLeft
-MagnificationControllerTest.PanWindowToRight
-WindowManagerTest.MouseEventCursors

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36cfb953ea04dac15159b516cd9ce741c6b7384b

commit 36cfb953ea04dac15159b516cd9ce741c6b7384b
Author: erg <erg@chromium.org>
Date: Wed Jun 21 19:41:45 2017

Implement cursor changing on Mushrome.

This splits AshNativeCursorManager into an interface and creates two
implementations: one for classic ash (the original code), and one for
mushrome. The new mushrome implementation forwards to the mus window
manager interface instead of the individual windows due to how mus gets
cursors only from windows which have event handlers.

This leaves some features unimplemented, such as cursor sets, but
implements the core interface.

BUG= 729798 , 734807 , 734809 

Review-Url: https://codereview.chromium.org/2932563002
Cr-Commit-Position: refs/heads/master@{#481278}

[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/BUILD.gn
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/shell.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/shell.h
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/test/cursor_manager_test_api.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/test/shell_test_api.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/test/shell_test_api.h
[delete] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/ash/wm/ash_native_cursor_manager.h
[add] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash.h
[rename] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_classic.cc
[add] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_classic.h
[rename] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_interactive_uitest.cc
[add] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_mus.cc
[add] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_mus.h
[rename] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ash/wm/native_cursor_manager_ash_unittest.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/chrome/test/BUILD.gn
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/testing/buildbot/filters/ash_unittests_mus.filter
[modify] https://crrev.com/36cfb953ea04dac15159b516cd9ce741c6b7384b/ui/views/widget/desktop_aura/desktop_native_cursor_manager.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c97be785b3d8cbb1d0d831c80c9401d108bde061

commit c97be785b3d8cbb1d0d831c80c9401d108bde061
Author: Elliot Glaysher <erg@chromium.org>
Date: Wed Jun 28 18:12:06 2017

Reenable WindowManagerTest.MouseEventCursors.

Bug:  734809 
Change-Id: I0a63ec8f3122d70792e64d8f77b8038886b24da3
Reviewed-on: https://chromium-review.googlesource.com/549989
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483062}
[modify] https://crrev.com/c97be785b3d8cbb1d0d831c80c9401d108bde061/testing/buildbot/filters/ash_unittests_mus.filter

Comment 3 by e...@chromium.org, Jun 28 2017

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment