New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734808 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 631103

Blocking:
issue 731255



Sign in to add a comment

Fix ash_unittests that uses ShellPortMash::IsMouseEventsEnabled

Project Member Reported by sky@chromium.org, Jun 19 2017

Issue description

ImmersiveFullscreenControllerTest.EndRevealViaGesture fails because  ShellPortMash::IsMouseEventsEnabled isn't wired up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f535f3e8476a4727232607d5d887409686405f45

commit f535f3e8476a4727232607d5d887409686405f45
Author: Elliot Glaysher <erg@chromium.org>
Date: Wed Jul 12 00:31:19 2017

Keep track of mouse events enabled in mus mode.

For mash, we'll have to port the current logic in CompountEventFilter to the
window server for keeping track of the mouse event enabled state, but for mus,
we can just use the existing cursor_manager().

Bug:  734808 , 637853 
Change-Id: I4b6a084732b643b6c8f94f091ee60852d9d07597
Reviewed-on: https://chromium-review.googlesource.com/565351
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485748}
[modify] https://crrev.com/f535f3e8476a4727232607d5d887409686405f45/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/f535f3e8476a4727232607d5d887409686405f45/testing/buildbot/filters/ash_unittests_mus.filter

Comment 2 by e...@chromium.org, Jul 12 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment