New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 734806 link

Starred by 2 users
Status: Archived
Owner:
█ e...@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 631103
Blocking:
issue 731255



Sign in to add a comment

Fix ash_unittests that depend upon wm::CursorManager

Project Member Reported by sky@chromium.org, Jun 19 2017 
There are a number of ash_unittests that currently fail in --mus because we are not creating CursorManager. Specifically this is the set of failing tests:

-AshNativeCursorManagerTest.FractionalScale
-AshNativeCursorManagerTest.LockCursor
-AshNativeCursorManagerTest.SetCursor
-AshNativeCursorManagerTest.SetCursorSet
-AshNativeCursorManagerTest.SetDeviceScaleFactorAndRotation
-AshNativeCursorManagerTest.UIScaleShouldNotChangeCursor
-CursorWindowControllerTest.VisibilityTest
-DragDropControllerTest.CaptureLostCancelsDragDrop
-DragDropControllerTest.DragCancelAcrossDisplays
-DragDropControllerTest.DragCancelOnDisplayDisconnect
-DragDropControllerTest.DragDropInMultipleViewsMultipleWidgetsTest
-DragDropControllerTest.DragDropInMultipleViewsSingleWidgetTest
-DragDropControllerTest.DragDropInSingleViewTest
-DragDropControllerTest.DragDropWithZeroDragUpdates
-DragDropControllerTest.PressingEscapeCancelsDragDrop
-DragDropControllerTest.SyntheticEventsDuringDragDrop
-DragDropControllerTest.TouchDragDropCancelsOnLongTap
-DragDropControllerTest.TouchDragDropCompletesOnFling
-DragDropControllerTest.TouchDragDropInMultipleWindows
-DragDropControllerTest.TouchDragDropLongTapGestureIsForwarded
-DragDropControllerTest.ViewRemovedWhileInDragDropTest
-DragDropControllerTest.WindowDestroyedDuringDragDrop
-DragWindowResizerTest.CursorDeviceScaleFactor
-ExtendedDesktopTest.TestCursor
-LockStateControllerTest.LegacyLockAndShutDown
-LockStateControllerTest.RequestShutdownFromLockScreen
-LockStateControllerTest.RequestShutdownFromLoginScreen
-LockStateControllerTest.ShutdownWithoutButton
-MouseCursorEventFilterTest.CursorDeviceScaleFactor
-PartialScreenshotControllerTest.LargeCursor
-PartialScreenshotControllerTest.VisibilityTest
-ResizeShadowAndCursorTest.MaximizeRestore
-ResizeShadowAndCursorTest.MouseDrag
-ResizeShadowAndCursorTest.MouseHover
-TooltipControllerTest.HideTooltipWhenCursorHidden
-WindowManagerTest.TestCursorClientObserver
-WindowManagerTest.UpdateCursorVisibility
-WindowManagerTest.UpdateCursorVisibilityAccelerator
-WindowManagerTest.UpdateCursorVisibilityOnKeyEvent
-WindowSelectorTest.Basic
-WindowTreeHostManagerTest.UpdateMouseLocationAfterDisplayChange_PrimaryDisconnected
-WindowTreeHostManagerTest.UpdateMouseLocationAfterDisplayChange_SwapPrimary
-WorkspaceWindowResizerTest.MouseMoveWithTouchDrag
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf104c1b3d2dfae83774369a9c6a890ad57b9d6e

commit bf104c1b3d2dfae83774369a9c6a890ad57b9d6e
Author: erg <erg@chromium.org>
Date: Sat Jun 24 01:01:12 2017

In mushrome, keep the state of the cursor locally.

In addition to telling the window server about state changes, record them
locally in the window manager so that queries about the current cursor state
return the correct values.

BUG= 734806 

Review-Url: https://codereview.chromium.org/2955623003
Cr-Commit-Position: refs/heads/master@{#482102}

[modify] https://crrev.com/bf104c1b3d2dfae83774369a9c6a890ad57b9d6e/ash/wm/native_cursor_manager_ash_mus.cc
[modify] https://crrev.com/bf104c1b3d2dfae83774369a9c6a890ad57b9d6e/testing/buildbot/filters/ash_unittests_mus.filter
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97ea635cc998b3d39de0c08695b8a8feb3aa974f

commit 97ea635cc998b3d39de0c08695b8a8feb3aa974f
Author: erg <erg@chromium.org>
Date: Thu Jun 29 21:45:09 2017

Make ShellPortMash dispatch to cursor_manager in mus mode.

In mus mode, we forward commands to the window manager for the actual
rendering of cursors, but the monolith ash/chrome process otherwise
doesn't change. When in mus mode, ShellPort commands should be
dispatched to our local cursor_manager(), so that things which read back
the cursor state return the correct values.

They should only dispatch directly to the window manager in mash mode.

BUG= 734806 

Review-Url: https://codereview.chromium.org/2957313003
Cr-Commit-Position: refs/heads/master@{#483500}

[modify] https://crrev.com/97ea635cc998b3d39de0c08695b8a8feb3aa974f/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/97ea635cc998b3d39de0c08695b8a8feb3aa974f/ash/wm/native_cursor_manager_ash_mus.cc
[modify] https://crrev.com/97ea635cc998b3d39de0c08695b8a8feb3aa974f/testing/buildbot/filters/ash_unittests_mus.filter

Comment 3 by e...@chromium.org, Jun 29 2017

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment