New issue
Advanced search Search tips

Issue 734782 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 734573
Owner: ----
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.7%-25.1% regression in system_health.memory_mobile at 480121:480277

Project Member Reported by chiniforooshan@chromium.org, Jun 19 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 19 2017

Cc: jinho.b...@samsung.com
Owner: jinho.b...@samsung.com

=== Auto-CCing suspected CL author jinho.bang@samsung.com ===

Hi jinho.bang@samsung.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jinho.bang
  Commit : 0b2fd946c81a4c7a26dcb6ed1c3957edb9acedcd
  Date   : Sat Jun 17 02:57:37 2017
  Subject: Revert of Make WebKitCSSMatrix an alias of DOMMatrix (patchset #16 id:300001 of https://codereview.chromium.org/2709763004/ )

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_tools/load_tools_weather
  Change       : 45.40% | 2895104.44444 -> 4209465.33333

Revision             Result                  N
chromium@480211      2895104 +- 1106968      9      good
chromium@480244      3002511 +- 1196593      9      good
chromium@480261      2743097 +- 433738       6      good
chromium@480269      2901476 +- 846198       6      good
chromium@480273      2947897 +- 1204865      9      good
chromium@480275      2759481 +- 523477       6      good
chromium@480276      3829903 +- 957144       6      bad       <--
chromium@480277      4209465 +- 838524       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.weather system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976319686142985376

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5795872589217792


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: -jinho.b...@samsung.com
Owner: ----
Well, that alert ( memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_tools/load_tools_weather) was not a bug; just a revert. But the other 5 regressions look suspicious. Will kick off another bisect.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jun 20 2017

Mergedinto: 734573
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Mike Reed
  Commit : 0c182fc77e044edddb6606b7cf51b9a5b6c2eb54
  Date   : Fri Jun 16 23:38:29 2017
  Subject: refactor lighting imagefilter to save codesize

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : smoothness.tough_filters_cases
  Metric       : frame_times/Filter Terrain SVG
  Change       : 11.52% | 205.477936508 -> 229.153800476

Revision                             Result                  N
chromium@480238                      205.478 +- 2.844        6      good
chromium@480257                      205.342 +- 3.01256      6      good
chromium@480267                      206.295 +- 1.38002      6      good
chromium@480270                      205.993 +- 2.61566      6      good
chromium@480271                      207.537 +- 3.10338      6      good
chromium@480271,skia@0c182fc77e      229.021 +- 2.60315      6      bad       <--
chromium@480271,skia@741d7261f2      227.893 +- 2.40321      6      bad
chromium@480272                      228.546 +- 2.68487      6      bad
chromium@480276                      229.154 +- 3.40676      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=Filter.Terrain.SVG smoothness.tough_filters_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8976294590163854976

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6384069971017728


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Sign in to add a comment