New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734753 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 22 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Recently/CCT offline pages API V2 tracking

Project Member Reported by chili@chromium.org, Jun 19 2017

Issue description

Design doc: https://docs.google.com/document/d/18MYjCxp38kArwvaVodicXOiigeDkT14ATVlT2lfVVLs/edit#

CL/feature tracking for CCT Offline Pages API V2
 
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/632a4d375b80847bbac51e7016be3f5d627a00fc

commit 632a4d375b80847bbac51e7016be3f5d627a00fc
Author: Cathy Li <chili@chromium.org>
Date: Thu Jun 29 19:51:58 2017

[Offline pages] Add support for request_origin in request queue store

Bug:  734753 
Change-Id: I0520e5363be38b13e2e2038b22a79e663e8c18cd
Reviewed-on: https://chromium-review.googlesource.com/548762
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483454}
[modify] https://crrev.com/632a4d375b80847bbac51e7016be3f5d627a00fc/components/offline_pages/core/background/request_queue_store_sql.cc
[modify] https://crrev.com/632a4d375b80847bbac51e7016be3f5d627a00fc/components/offline_pages/core/background/request_queue_store_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a340de7b62f2749e7f913cc6b185a023938d4e9

commit 7a340de7b62f2749e7f913cc6b185a023938d4e9
Author: Cathy Li <chili@chromium.org>
Date: Thu Jul 06 20:37:14 2017

[Offline pages] Propagate request_origin to SavePageParams; Add request_origin to SavePageLaterParams

Bug:  734753 
Change-Id: I1ff0cff1d11248dc048c18111519eef24aa7ed3c
Reviewed-on: https://chromium-review.googlesource.com/553757
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484733}
[modify] https://crrev.com/7a340de7b62f2749e7f913cc6b185a023938d4e9/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/7a340de7b62f2749e7f913cc6b185a023938d4e9/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
[modify] https://crrev.com/7a340de7b62f2749e7f913cc6b185a023938d4e9/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/7a340de7b62f2749e7f913cc6b185a023938d4e9/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/7a340de7b62f2749e7f913cc6b185a023938d4e9/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/7a340de7b62f2749e7f913cc6b185a023938d4e9/components/offline_pages/core/background/request_coordinator.h
[modify] https://crrev.com/7a340de7b62f2749e7f913cc6b185a023938d4e9/components/offline_pages/core/background/request_coordinator_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/631445be34ac99a77e79b39bd62677360f5fd9d4

commit 631445be34ac99a77e79b39bd62677360f5fd9d4
Author: Cathy Li <chili@chromium.org>
Date: Wed Jul 12 23:51:37 2017

[Offline pages] Wrap page deletion notification parameters into one struct.

Also add request_origin to this struct.

Bug:  734753 
Change-Id: I210bf0fa177f1379693b6b432c12f48b89d8cd28
Reviewed-on: https://chromium-review.googlesource.com/558564
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486160}
[add] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/DeletedPageInfo.java
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsOfflineModelObserver.java
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/android/java_sources.gni
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/browser/android/offline_pages/offline_page_bridge.h
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/browser/ntp_snippets/download_suggestions_provider.h
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/ntp_snippets/remote/prefetched_pages_tracker_impl.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/ntp_snippets/remote/prefetched_pages_tracker_impl.h
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/ntp_snippets/remote/prefetched_pages_tracker_impl_unittest.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/offline_pages/core/offline_page_model.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/offline_pages/core/offline_page_model_impl.cc
[modify] https://crrev.com/631445be34ac99a77e79b39bd62677360f5fd9d4/components/offline_pages/core/offline_page_model_impl_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7187388fa9156694d365b26ab34109578163a449

commit 7187388fa9156694d365b26ab34109578163a449
Author: Cathy Li <chili@chromium.org>
Date: Wed Aug 09 15:34:51 2017

[Offline pages]: Add ability to attribute download button clicks to apps

Bug:  734753 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia3cf2158295dc7243d4659938673a25ce44594d3
Reviewed-on: https://chromium-review.googlesource.com/560799
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492994}
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java
[add] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageOrigin.java
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/java_sources.gni
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
[add] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageOriginUnitTest.java
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/android/offline_page_bridge.h
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/offline_page_tab_helper.h
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/offline_page_utils.h
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/resources/offline_pages/offline_internals.html
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/resources/offline_pages/offline_internals.js
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
[modify] https://crrev.com/7187388fa9156694d365b26ab34109578163a449/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d0ba8d8b85c3d67367269956d62d51515232fd

commit a6d0ba8d8b85c3d67367269956d62d51515232fd
Author: Cathy Li <chili@chromium.org>
Date: Thu Aug 10 18:52:35 2017

[Offline pages]: Add ability to notify apps when pages attributed to them have
been changed.

Bug:  734753 
Change-Id: I1e821146ccade5ffd8c19c190fb82f305bfd9a2e
Reviewed-on: https://chromium-review.googlesource.com/560796
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493480}
[modify] https://crrev.com/a6d0ba8d8b85c3d67367269956d62d51515232fd/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[add] https://crrev.com/a6d0ba8d8b85c3d67367269956d62d51515232fd/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/CctOfflinePageModelObserver.java
[modify] https://crrev.com/a6d0ba8d8b85c3d67367269956d62d51515232fd/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageOrigin.java
[modify] https://crrev.com/a6d0ba8d8b85c3d67367269956d62d51515232fd/chrome/android/java_sources.gni
[modify] https://crrev.com/a6d0ba8d8b85c3d67367269956d62d51515232fd/chrome/browser/BUILD.gn
[add] https://crrev.com/a6d0ba8d8b85c3d67367269956d62d51515232fd/chrome/browser/offline_pages/android/cct_origin_observer.cc
[add] https://crrev.com/a6d0ba8d8b85c3d67367269956d62d51515232fd/chrome/browser/offline_pages/android/cct_origin_observer.h
[rename] https://crrev.com/a6d0ba8d8b85c3d67367269956d62d51515232fd/chrome/browser/offline_pages/android/offline_page_model_factory.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6

commit 9aec0a20553e23c33ab7ace1f93a0adfd969d6f6
Author: Cathy Li <chili@chromium.org>
Date: Wed Aug 16 01:05:57 2017

[Offline pages] Add ability to query pages by their request origin

Bug:  734753 
Change-Id: I5efecc3de0ab7c390fb84f90e3ec21ae05d4e9dc
Reviewed-on: https://chromium-review.googlesource.com/574971
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494649}
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/chrome/browser/offline_pages/android/offline_page_bridge.h
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/offline_page_model_impl.cc
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/offline_page_model_impl.h
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/offline_page_model_query.cc
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/offline_page_model_query.h
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/offline_page_model_query_unittest.cc
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/stub_offline_page_model.cc
[modify] https://crrev.com/9aec0a20553e23c33ab7ace1f93a0adfd969d6f6/components/offline_pages/core/stub_offline_page_model.h

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf17ffb3d1f80c5b1ff572a3b2d4d75ced291522

commit bf17ffb3d1f80c5b1ff572a3b2d4d75ced291522
Author: Cathy Li <chili@chromium.org>
Date: Wed Aug 16 17:13:27 2017

[Offline pages] Change return type of whitelist from String[] to List<String>.

Non-empty arrays are mutable where as lists can be made immutable.

Bug:  734753 
Change-Id: I6be73ee9a0573e332a66394a5973e97e47e5abb6
Reviewed-on: https://chromium-review.googlesource.com/615848
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494837}
[modify] https://crrev.com/bf17ffb3d1f80c5b1ff572a3b2d4d75ced291522/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[modify] https://crrev.com/bf17ffb3d1f80c5b1ff572a3b2d4d75ced291522/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/CctOfflinePageModelObserver.java

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f0ac7d5ecff04ffec2466b50869b58b53e9f632

commit 4f0ac7d5ecff04ffec2466b50869b58b53e9f632
Author: Cathy Li <chili@chromium.org>
Date: Thu Aug 17 21:58:11 2017

[Offline pages] Passing additional offline page item fields to Java side

These are used for passing additional page information back through CCT API.

Bug:  734753 
Change-Id: Ibc407234577637e174242787bd773fc33f42df72
Reviewed-on: https://chromium-review.googlesource.com/614200
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495337}
[modify] https://crrev.com/4f0ac7d5ecff04ffec2466b50869b58b53e9f632/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/4f0ac7d5ecff04ffec2466b50869b58b53e9f632/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java
[modify] https://crrev.com/4f0ac7d5ecff04ffec2466b50869b58b53e9f632/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java
[modify] https://crrev.com/4f0ac7d5ecff04ffec2466b50869b58b53e9f632/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
[modify] https://crrev.com/4f0ac7d5ecff04ffec2466b50869b58b53e9f632/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
[modify] https://crrev.com/4f0ac7d5ecff04ffec2466b50869b58b53e9f632/chrome/browser/offline_pages/android/offline_page_bridge.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/5c9e7e95c792101e628a97f9019be78dbcbe9317

commit 5c9e7e95c792101e628a97f9019be78dbcbe9317
Author: Cathy Li <chili@google.com>
Date: Mon Aug 21 21:06:21 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3652356291c1a340f9db027841f7b402a543978c

commit 3652356291c1a340f9db027841f7b402a543978c
Author: Cathy Li <chili@chromium.org>
Date: Tue Aug 22 18:00:42 2017

[Offline pages] Allow creation of OfflinePageOrigin by uid and context

Bug:  734753 
Change-Id: I6916bc7981e5e043aa5bf1df1e67d02ea7553b15
Reviewed-on: https://chromium-review.googlesource.com/623035
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496363}
[modify] https://crrev.com/3652356291c1a340f9db027841f7b402a543978c/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageOrigin.java

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ed5a8404a3c362f8bc11b8019f92747396b93d

commit 69ed5a8404a3c362f8bc11b8019f92747396b93d
Author: Cathy Li <chili@chromium.org>
Date: Fri Aug 25 23:03:50 2017

[Offline pages] Page attribution for dino pages

Bug:  734753 
Change-Id: I727bfc369c6a4df024be5d77910aca3b80ce6b15
Reviewed-on: https://chromium-review.googlesource.com/622291
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497582}
[modify] https://crrev.com/69ed5a8404a3c362f8bc11b8019f92747396b93d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/69ed5a8404a3c362f8bc11b8019f92747396b93d/chrome/browser/BUILD.gn
[modify] https://crrev.com/69ed5a8404a3c362f8bc11b8019f92747396b93d/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/69ed5a8404a3c362f8bc11b8019f92747396b93d/chrome/browser/offline_pages/android/offline_page_bridge.h
[add] https://crrev.com/69ed5a8404a3c362f8bc11b8019f92747396b93d/chrome/browser/offline_pages/android/offline_page_origin_utils_android.cc
[add] https://crrev.com/69ed5a8404a3c362f8bc11b8019f92747396b93d/chrome/browser/offline_pages/offline_page_origin_utils.h
[modify] https://crrev.com/69ed5a8404a3c362f8bc11b8019f92747396b93d/chrome/browser/offline_pages/offline_page_utils.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8a5f91aedd4a01136c7080df35dca251ec3cfe7

commit a8a5f91aedd4a01136c7080df35dca251ec3cfe7
Author: Cathy Li <chili@chromium.org>
Date: Mon Aug 28 18:26:59 2017

[Offline pages] Add offline pages ctv2 feature to be exposed on java side

Bug:  734753 
Change-Id: I5441f5d728e6257980dae4f3b5ae598bce46c542
Reviewed-on: https://chromium-review.googlesource.com/637045
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497811}
[modify] https://crrev.com/a8a5f91aedd4a01136c7080df35dca251ec3cfe7/chrome/browser/android/chrome_feature_list.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/88018a52e2cf156d8b2ea208ebde7fb789b5556f

commit 88018a52e2cf156d8b2ea208ebde7fb789b5556f
Author: Cathy Li <chili@google.com>
Date: Wed Aug 30 02:43:45 2017

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4497956f8c93aecc5115f5a7e2595ea2d62e2b86

commit 4497956f8c93aecc5115f5a7e2595ea2d62e2b86
Author: Cathy Li <chili@chromium.org>
Date: Thu Sep 21 00:37:51 2017

[Offline pages] Prepend the broadcast action with package name

Bug:  734753 
Change-Id: Ifd0477431e8eeb975897997c7de33da0ec0272c8
Reviewed-on: https://chromium-review.googlesource.com/668030
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503295}
[modify] https://crrev.com/4497956f8c93aecc5115f5a7e2595ea2d62e2b86/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/CctOfflinePageModelObserver.java

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/4ad7bc629d80eb8a9e34027b96b6805bc893454c

commit 4ad7bc629d80eb8a9e34027b96b6805bc893454c
Author: Cathy Li <chili@google.com>
Date: Mon Oct 09 18:48:02 2017

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9c890b611a8f3e15ba2a1945117f3da8bd17720

commit d9c890b611a8f3e15ba2a1945117f3da8bd17720
Author: Cathy Li <chili@chromium.org>
Date: Mon Oct 16 18:43:58 2017

[Offline pages]: Add pending intent to offline pages changed broadcast to help
with origin verification.

Bug:  734753 
Change-Id: Id9a1c8a62a038780616e8a0e754893a64ad9368a
Reviewed-on: https://chromium-review.googlesource.com/714303
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509119}
[modify] https://crrev.com/d9c890b611a8f3e15ba2a1945117f3da8bd17720/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/CctOfflinePageModelObserver.java

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/450c03a8d62ceb55e6c64ca003474ae623fed5fc

commit 450c03a8d62ceb55e6c64ca003474ae623fed5fc
Author: Cathy Li <chili@chromium.org>
Date: Wed Nov 22 19:34:43 2017

[Offline pages] Context menu attribution

Attribute downloads from CCT's context menu (right click -> download link)
to the app that initiated the custom tab

Bug:  734753 
Change-Id: I6e9f77bc1a9811f5322a732e6d2431f43bf1044c
Reviewed-on: https://chromium-review.googlesource.com/615107
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518711}
[modify] https://crrev.com/450c03a8d62ceb55e6c64ca003474ae623fed5fc/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/450c03a8d62ceb55e6c64ca003474ae623fed5fc/chrome/browser/offline_pages/downloads/resource_throttle.cc
[modify] https://crrev.com/450c03a8d62ceb55e6c64ca003474ae623fed5fc/content/browser/download/download_request_core.cc
[modify] https://crrev.com/450c03a8d62ceb55e6c64ca003474ae623fed5fc/content/public/browser/BUILD.gn
[add] https://crrev.com/450c03a8d62ceb55e6c64ca003474ae623fed5fc/content/public/browser/download_request_utils.h

Comment 22 by chili@chromium.org, Nov 27 2017

Status: Fixed (was: Started)
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/818af15972aa9a61e5f940d9c43aafdb6ce8224d

commit 818af15972aa9a61e5f940d9c43aafdb6ce8224d
Author: Cathy Li <chili@chromium.org>
Date: Tue Dec 19 05:51:44 2017

Update fieldtrial testing to include recently flag.

Bug:  734753 
Change-Id: Ib277c9517de6fc24debb3b01fa8a623560cfe16c
Reviewed-on: https://chromium-review.googlesource.com/833491
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524950}
[modify] https://crrev.com/818af15972aa9a61e5f940d9c43aafdb6ce8224d/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment