Issue metadata
Sign in to add a comment
|
css3/blending/background-blend-mode-gif-color-2.html is failing on Mac10.10 |
||||||||||||||||||||||
Issue descriptionwebkit_tests failing on chromium.webkit/WebKit Mac10.10 Builders failed on: - WebKit Mac10.10: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10
,
Jun 19 2017
Actually, I think I can handle this
,
Jun 20 2017
Patch in the queue: https://chromium-review.googlesource.com/c/540141/
,
Jun 20 2017
,
Jun 20 2017
This patch failed to fix the problem. This test is just flaky on all platforms. I will suppress the test and assign to the paint team for triage.
,
Jun 20 2017
,
Jun 20 2017
Ah, good ol' background-blend-mode-gif-color-2.html. That test needs some TLC, it's super fragile - see issue 729075 also. (recent timing changes in Skia blending might have exacerbated its flakiness)
,
Jun 20 2017
https://chromium-review.googlesource.com/c/540787/ has landed (accidentally put the wrong bug id) so this is now suppressed and ready for someone to look into further.
,
Jun 20 2017
Florin to the rescue! https://chromium-review.googlesource.com/c/541037/
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24c9f587451ae73f0a3d826dccb362913fb2ddc6 commit 24c9f587451ae73f0a3d826dccb362913fb2ddc6 Author: Florin Malita <fmalita@chromium.org> Date: Wed Jun 21 01:44:53 2017 Deflake background-blend-mode-gif-color-2.html The test is attempting to catch the second frame of an animated GIF (2 x 400ms frames) using setTimeout(400). This is super-fragile. Refactor to use advanceImageAnimation() intead. BUG= chromium:734733 , chromium:729075 Change-Id: I1528e602bed7f9599cb3bbf9a2821354a2e7aaef Reviewed-on: https://chromium-review.googlesource.com/541037 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#481075} [modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2-expected.png [modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2.html
,
Jun 21 2017
,
Jun 21 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pdr@chromium.org
, Jun 19 2017Owner: reed@chromium.org
Status: Assigned (was: Available)