New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734733 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

css3/blending/background-blend-mode-gif-color-2.html is failing on Mac10.10

Project Member Reported by pdr@chromium.org, Jun 19 2017

Issue description

webkit_tests failing on chromium.webkit/WebKit Mac10.10

Builders failed on: 
- WebKit Mac10.10: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10



 

Comment 1 by pdr@chromium.org, Jun 19 2017

Cc: fmalita@chromium.org
Owner: reed@chromium.org
Status: Assigned (was: Available)
This was due to a bad baseline in https://codereview.chromium.org/2935363002

These baselines actually look wrong. I'm going to suppress this failure for now.

Comment 2 by pdr@chromium.org, Jun 19 2017

Cc: reed@chromium.org
Owner: pdr@chromium.org
Actually, I think I can handle this

Comment 3 by pdr@chromium.org, Jun 20 2017

Comment 4 by hayato@chromium.org, Jun 20 2017

Labels: -Sheriff-Chromium

Comment 5 by pdr@chromium.org, Jun 20 2017

Cc: tmartino@chromium.org
This patch failed to fix the problem. This test is just flaky on all platforms. I will suppress the test and assign to the paint team for triage.

Comment 6 by pdr@chromium.org, Jun 20 2017

Cc: pdr@chromium.org
Components: Blink>Paint
Labels: OS-All
Owner: ----
Status: Available (was: Assigned)
Ah, good ol' background-blend-mode-gif-color-2.html.

That test needs some TLC, it's super fragile - see  issue 729075  also.

(recent timing changes in Skia blending might have exacerbated its flakiness)

Comment 8 by pdr@chromium.org, Jun 20 2017

https://chromium-review.googlesource.com/c/540787/ has landed (accidentally put the wrong bug id) so this is now suppressed and ready for someone to look into further.

Comment 9 by pdr@chromium.org, Jun 20 2017

Florin to the rescue!
https://chromium-review.googlesource.com/c/541037/
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24c9f587451ae73f0a3d826dccb362913fb2ddc6

commit 24c9f587451ae73f0a3d826dccb362913fb2ddc6
Author: Florin Malita <fmalita@chromium.org>
Date: Wed Jun 21 01:44:53 2017

Deflake background-blend-mode-gif-color-2.html

The test is attempting to catch the second frame of an animated GIF
(2 x 400ms frames) using setTimeout(400).  This is super-fragile.

Refactor to use advanceImageAnimation() intead.

BUG= chromium:734733 , chromium:729075 

Change-Id: I1528e602bed7f9599cb3bbf9a2821354a2e7aaef
Reviewed-on: https://chromium-review.googlesource.com/541037
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481075}
[modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2-expected.png
[modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2.html

Comment 11 by pdr@chromium.org, Jun 21 2017

Cc: mtklein@chromium.org reed@google.com
 Issue 729075  has been merged into this issue.
Status: Fixed (was: Available)

Sign in to add a comment