New issue
Advanced search Search tips

Issue 734732 link

Starred by 1 user
Status: WontFix
Owner:
wzang@chromium.org
Closed: Jan 2018
Cc:
r...@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Submitting PIN via keyboard shortcuts only is broken on webui lock screen

Project Member Reported by jdufault@chromium.org, Jun 19 2017 
Using tab to select the PIN keyboard (ie, 1), hit enter. It fires an event on both the PIN keyboard and the submit button, which causes the PIN attempt to be rejected since it has not been fully typed yet.

Comment 1 by wzang@chromium.org, Jun 21 2017 

The same issue exists in the old UI too. 

It's a little tricky to prevent the password entry container from handling the key down event. I've tried adding an additional line in [1] to check if the focus is on one of the buttons in PIN keyboard. The function that does the actual checking (e.g. isButtonFocused) should belong to pin-keyboard in [2]. But it doesn't work. Still working on this.

[1] https://cs.chromium.org/chromium/src/ui/login/account_picker/md_user_pod_row.js?q=md_user_pod_row.js&l=4594
[2]
https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.js?l=51

Comment 2 by weifangsun@chromium.org, Jan 19 2018

Components: UI>Shell>LockScreen

Comment 3 by jdufault@chromium.org, Jan 19 2018

Status: WontFix (was: Assigned)
webui lock is no longer used.
►

Sign in to add a comment