"SiteEngagementBrowserTest.All" is flaky |
||||||
Issue description"SiteEngagementBrowserTest.All" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKAsSBUZsYWtlIh1TaXRlRW5nYWdlbWVudEJyb3dzZXJUZXN0LkFsbAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 20 2017
,
Jun 20 2017
For whatever reason, the CL turning this off didn't get posted back to the bug: https://chromium-review.googlesource.com/c/540069/ Assigning to calamity@, who has the last change on this test.
,
Jun 20 2017
,
Jun 21 2017
The flakes seem to only be on Windows, re-enabling for other platforms. The logs point to something in Mojo in test startup. Things are changing there and this may be fixed as a side-effect. Will re-examine Windows when that happens.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/531ddbacfa806e9103677d34d3344e117515fdf4 commit 531ddbacfa806e9103677d34d3344e117515fdf4 Author: calamity <calamity@chromium.org> Date: Wed Jun 21 09:42:00 2017 Reenable SiteEngagementBrowserTest.All for non-Windows platforms. BUG= 734716 Review-Url: https://codereview.chromium.org/2953553002 Cr-Commit-Position: refs/heads/master@{#481158} [modify] https://crrev.com/531ddbacfa806e9103677d34d3344e117515fdf4/chrome/test/data/webui/engagement/site_engagement_browsertest.js
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1961b00b0ac7bd6b490cd47c8834feceb58a083d commit 1961b00b0ac7bd6b490cd47c8834feceb58a083d Author: Christopher Lam <calamity@chromium.org> Date: Wed Jul 18 05:59:07 2018 Reenable SiteEngagementBrowserTest.All for Windows. This may have been fixed, re-enabling to gather data. BUG= 734716 Change-Id: If5400ae8e7ee202ba367d6f7fdeb71a1e4798ff7 Reviewed-on: https://chromium-review.googlesource.com/1140018 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#575955} [modify] https://crrev.com/1961b00b0ac7bd6b490cd47c8834feceb58a083d/chrome/test/data/webui/engagement/site_engagement_browsertest.js
,
Jul 19
No flakes for a day, gonna mark this fixed for now. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tmartino@chromium.org
, Jun 19 2017Status: Started (was: Untriaged)