New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 734686 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

60kb regression in resource_sizes (MonochromePublic.apk) at 480214:480214

Project Member Reported by estevenson@chromium.org, Jun 19 2017

Issue description

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=734686

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg9ozGogkM


Bot(s) for this bug's original alert(s):

Android Builder
Description: Show this description
"tools/binary_size/diagnose_bloat.py 5b9839ca209cd11c4d899fa92202a280a5c9d222 --cloud -v" reports:

21 symbols added (+), 1645 changed (~), 14 removed (-), 485346 unchanged (not shown)
Number of unique symbols 377202 -> 377205 (+3)
0 paths added, 2 removed, 204 changed

Showing 487,026 symbols (aliases not grouped for diffs) with total pss: 60047 bytes
.text=58.6kb     .rodata=0 bytes    .data*=16 bytes   .bss=0 bytes    total=58.6kb
Number of unique paths: 15633

Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0)        780 (1.3%)  t@Group      +780 (0->0)        {{no path}}
               ** symbol gaps (count=9)
+ 1)       1122 (1.9%)  t@0x865e38   +342 (0->340)      mojo/public/cpp/bindings/lib/message.cc
               mojo::Message::Message
+ 2)       1294 (2.2%)  t@0x86617c   +172 (0->172)      mojo/public/cpp/bindings/lib/message.cc
               mojo::Message::AttachHandles
+ 3)       1428 (2.4%)  t@0x865f8c   +134 (0->134)      mojo/public/cpp/bindings/lib/message.cc
               mojo::Message::Message
~ 4)       1298 (2.2%)  t@0x86626a   -130 (148->18)     mojo/public/cpp/bindings/lib/message.cc
               mojo::Message::TakeMojoMessage
- 5)       1168 (1.9%)  t@0x0        -130 (130->0)      mojo/public/cpp/bindings/lib/message_builder.cc
               mojo::internal::MessageBuilder::MessageBuilder
- 6)       1066 (1.8%)  t@0x0        -102 (102->0)      mojo/public/cpp/bindings/lib/message_buffer.cc
               mojo::internal::MessageBuffer::MessageBuffer
~ 7)       1164 (1.9%)  t@0x14507e8  +98 (394->492)     third_party/WebKit/public/platform/modules/websockets/websocket.mojom-blink.cc
               blink::mojom::blink::WebSocketProxy::AddChannelRequest
- 8)       1066 (1.8%)  t@0x0        -98 (98->0)        mojo/public/cpp/bindings/lib/{{shared}}/2
               mojo::GetSerializedMessageContents
~ 9)       1158 (1.9%)  t@0x14c5084  +92 (288->380)     components/spellcheck/common/spellcheck.mojom.cc
               spellcheck::mojom::SpellCheckerProxy::CustomDictionaryChanged
~ 10)      1248 (2.1%)  t@0xb006e4   +90 (218->308)     content/common/url_loader.mojom.cc
               content::mojom::URLLoaderClientProxy::OnReceiveResponse
~ 11)      1338 (2.2%)  t@0xae30e8   +90 (210->300)     content/common/indexed_db/indexed_db.mojom.cc
               indexed_db::mojom::CursorProxy::PrefetchReset
~ 12)      1428 (2.4%)  t@0xa23408   +90 (254->344)     services/preferences/public/interfaces/preferences.mojom.cc
               prefs::mojom::PersistentPrefStoreProxy::RequestValue
~ 13)      1516 (2.5%)  t@0x145372c  +88 (292->380)     third_party/WebKit/public/platform/modules/payments/payment_request.mojom-blink.cc
               payments::mojom::blink::PaymentRequestProxy::Init
~ 14)      1604 (2.7%)  t@0xa22c2c   +88 (424->512)     services/preferences/public/interfaces/preferences.mojom.cc
               prefs::mojom::PrefStoreConnector_Connect_ProxyToResponder::Run
~ 15)      1692 (2.8%)  t@0xa278dc   +88 (388->476)     services/preferences/public/interfaces/tracked_preference_validation_delegate.mojom.cc
               prefs::mojom::TrackedPreferenceValidationDelegateProxy::OnSplitPreferenceValidation
~ 16)      1778 (3.0%)  t@0xb578ac   +86 (218->304)     third_party/WebKit/public/platform/modules/permissions/permission.mojom.cc
               blink::mojom::PermissionServiceProxy::AddPermissionObserver
~ 17)      1864 (3.1%)  t@0x1472024  +86 (170->256)     third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom-blink.cc
               blink::mojom::blink::OffscreenCanvasProviderProxy::CreateCompositorFrameSink
~ 18)      1950 (3.2%)  t@0x144fac0  +86 (218->304)     third_party/WebKit/public/platform/modules/permissions/permission.mojom-blink.cc
               blink::mojom::blink::PermissionServiceProxy::AddPermissionObserver
~ 19)      2036 (3.4%)  t@0xaeb300   +86 (314->400)     content/common/leveldb_wrapper.mojom.cc
               content::mojom::LevelDBObserverProxy::KeyAdded
~ 20)      2122 (3.5%)  t@0xaeb674   +86 (314->400)     content/common/leveldb_wrapper.mojom.cc
               content::mojom::LevelDBObserverProxy::KeyDeleted
~ 21)      2208 (3.7%)  t@0xae2790   +86 (166->252)     content/common/indexed_db/indexed_db.mojom.cc
               indexed_db::mojom::DatabaseCallbacksProxy::Abort
~ 22)      2294 (3.8%)  t@0xae4b6c   +86 (194->280)     content/common/indexed_db/indexed_db.mojom.cc
               indexed_db::mojom::DatabaseProxy::AckReceivedBlobs
~ 23)      2380 (4.0%)  t@0xae48fc   +86 (178->264)     content/common/indexed_db/indexed_db.mojom.cc
               indexed_db::mojom::DatabaseProxy::RenameIndex
~ 24)      2466 (4.1%)  t@0xae37cc   +86 (170->256)     content/common/indexed_db/indexed_db.mojom.cc
               indexed_db::mojom::DatabaseProxy::RenameObjectStore
~ 25)      2552 (4.2%)  t@0x14c4f0c  +86 (290->376)     components/spellcheck/common/spellcheck.mojom.cc
               spellcheck::mojom::SpellCheckerProxy::Initialize
~ 26)      2638 (4.4%)  t@0xe72c84   +86 (182->268)     services/ui/gpu/interfaces/gpu_main.mojom.cc
               ui::mojom::GpuMainProxy::CreateGpuService
~ 27)      2722 (4.5%)  t@0xe990b0   +84 (256->340)     components/autofill/content/common/autofill_driver.mojom.cc
               autofill::mojom::PasswordManagerClientProxy::ShowPasswordGenerationPopup
~ 28)      2806 (4.7%)  t@0xb4d8b8   +84 (280->364)     third_party/WebKit/public/platform/modules/app_banner/app_banner.mojom.cc
               blink::mojom::AppBannerControllerProxy::BannerPromptRequest
~ 29)      2890 (4.8%)  t@0xb5c8a8   +84 (200->284)     third_party/WebKit/public/platform/modules/websockets/websocket.mojom.cc
               blink::mojom::WebSocketClientProxy::OnDataFrame
~ 30)      2974 (5.0%)  t@0x1471f04  +84 (204->288)     third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom-blink.cc
               blink::mojom::blink::OffscreenCanvasProviderProxy::CreateOffscreenCanvasSurface
~ 31)      3058 (5.1%)  t@0x14509d4  +84 (196->280)     third_party/WebKit/public/platform/modules/websockets/websocket.mojom-blink.cc
               blink::mojom::blink::WebSocketProxy::SendFrame
~ 32)      3142 (5.2%)  t@0xaf7394   +84 (192->276)     content/common/service_worker/embedded_worker.mojom.cc
               content::mojom::EmbeddedWorkerInstanceClientProxy::StartWorker
~ 33)      3226 (5.4%)  t@0xae95d0   +84 (192->276)     content/common/input/input_handler.mojom.cc

Comment 5 Deleted

Owner: roc...@chromium.org
Status: WontFix (was: Untriaged)
This change was reverted: ece06fd86a0338d4d79364a494f58ff2810bdec7.

rocket@ - This is just an FYI but it would be great if some of the size jump could be addressed in the reland!

You should be able to check the size jump locally via "tools/binary_size/diagnose_bloat.py HEAD -v".

Comment 7 by roc...@chromium.org, Jun 19 2017

Cc: yzshen@chromium.org
Status: Assigned (was: WontFix)
The change was already relanded and I see the same regression there: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=480303

This is surprising.

Comment 8 by roc...@chromium.org, Jun 19 2017

Cc: thestig@chromium.org tapted@chromium.org roc...@chromium.org chiniforooshan@chromium.org
 Issue 734726  has been merged into this issue.
Cc: -thestig@chromium.org

Comment 11 Deleted

Status: Fixed (was: Assigned)
Perf graphs are showing a reduction of 73700 bytes for the fix, even larger than the original jump! Thanks for looking into this.

Commit: f7a2fe16b76477dd173f099916e5028a5cf99c5f

Graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=480739

Sign in to add a comment